public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jth@kernel.org>
To: linux-btrfs@vger.kernel.org
Cc: Josef Bacik <josef@toxicpanda.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	David Sterba <dsterba@suse.com>,
	Naohiro Aota <naohiro.aota@wdc.com>, Qu Wenruo <wqu@suse.com>,
	Filipe Manana <fdmanana@suse.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Johannes Thumshirn <jth@kernel.org>
Subject: [PATCH 00/14] btrfs: more RST delete fixes
Date: Thu, 12 Dec 2024 08:55:19 +0100	[thread overview]
Message-ID: <cover.1733989299.git.jth@kernel.org> (raw)

Here's another set of fixes for the delete path on RAID stripe-tree backed
filesystems.

Josef's CI system started tripping over a bad key order due to the usage
of btrfs_set_item_key_safe() in btrfs_partially_delete_raid_extent() and
while investigating what is happening there I found more bugs and not
handled corner cases, which resulted in more fixes and test-cases.

Unfortunately I couldn't fix the bad key order problem and had to resort
to re-creating the item in btrfs_partially_delete_raid_extent() and insert
the new one after deleting the old.

Fstests btrfs/06* are extremely good in exhibiting these failures and
btrfs/060 has been extensively run while developing this series.

A full CI run is undergoing at the moment:
https://github.com/btrfs/linux/actions/runs/12291668397

Johannes Thumshirn (14):
  btrfs: don't try to delete RAID stripe-extents if we don't need to
  btrfs: assert RAID stripe-extent length is always greater than 0
  btrfs: fix search when deleting a RAID stripe-extent
  btrfs: fix front delete range calculation for RAID stripe extents
  btrfs: fix tail delete of RAID stripe-extents
  btrfs: fix deletion of a range spanning parts two RAID stripe extents
  btrfs: implement hole punching for RAID stripe extents
  btrfs: don't use btrfs_set_item_key_safe on RAID stripe-extents
  btrfs: selftests: check for correct return value of failed lookup
  btrfs: selftests: don't split RAID extents in half
  btrfs: selftests: test RAID stripe-tree deletion spanning two items
  btrfs: selftests: add selftest for punching holes into the RAID stripe
    extents
  btrfs: selftests: add test for punching a hole into 3 RAID
    stripe-extents
  btrfs: selftests: add a selftest for deleting two out of three extents

 fs/btrfs/ctree.c                        |   1 +
 fs/btrfs/raid-stripe-tree.c             | 154 +++++-
 fs/btrfs/tests/raid-stripe-tree-tests.c | 653 +++++++++++++++++++++++-
 3 files changed, 776 insertions(+), 32 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-12-12  7:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  7:55 Johannes Thumshirn [this message]
2024-12-12  7:55 ` [PATCH 01/14] btrfs: don't try to delete RAID stripe-extents if we don't need to Johannes Thumshirn
2024-12-17 14:40   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 02/14] btrfs: assert RAID stripe-extent length is always greater than 0 Johannes Thumshirn
2024-12-17 14:46   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 03/14] btrfs: fix search when deleting a RAID stripe-extent Johannes Thumshirn
2024-12-17 14:56   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 04/14] btrfs: fix front delete range calculation for RAID stripe extents Johannes Thumshirn
2024-12-17 15:02   ` Filipe Manana
2024-12-18  9:55     ` Johannes Thumshirn
2024-12-12  7:55 ` [PATCH 05/14] btrfs: fix tail delete of RAID stripe-extents Johannes Thumshirn
2024-12-17 15:45   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 06/14] btrfs: fix deletion of a range spanning parts two RAID stripe extents Johannes Thumshirn
2024-12-17 15:58   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 07/14] btrfs: implement hole punching for " Johannes Thumshirn
2024-12-17 16:05   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 08/14] btrfs: don't use btrfs_set_item_key_safe on RAID stripe-extents Johannes Thumshirn
2024-12-17 16:23   ` Filipe Manana
2024-12-18 10:00     ` Johannes Thumshirn
2024-12-19 10:03     ` Johannes Thumshirn
2024-12-12  7:55 ` [PATCH 09/14] btrfs: selftests: check for correct return value of failed lookup Johannes Thumshirn
2024-12-17 16:24   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 10/14] btrfs: selftests: don't split RAID extents in half Johannes Thumshirn
2024-12-17 16:31   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 11/14] btrfs: selftests: test RAID stripe-tree deletion spanning two items Johannes Thumshirn
2024-12-17 16:43   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 12/14] btrfs: selftests: add selftest for punching holes into the RAID stripe extents Johannes Thumshirn
2024-12-17 16:50   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 13/14] btrfs: selftests: add test for punching a hole into 3 RAID stripe-extents Johannes Thumshirn
2024-12-17 16:55   ` Filipe Manana
2024-12-12  7:55 ` [PATCH 14/14] btrfs: selftests: add a selftest for deleting two out of three extents Johannes Thumshirn
2024-12-17 16:59   ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1733989299.git.jth@kernel.org \
    --to=jth@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=dsterba@suse.com \
    --cc=fdmanana@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox