From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs: move ordered extents cleanup to where they got allocated
Date: Mon, 13 Jan 2025 20:12:11 +1030 [thread overview]
Message-ID: <cover.1736759698.git.wqu@suse.com> (raw)
Currently ordered extents cleanup is delayed, e.g:
Cow_file_range() and run_delalloc_nocow() all can allocate ordered
extents by themselves.
But the ordered extents cleanup is not happending in those functions,
but at the caller, btrfs_run_delalloc_range().
This is not the common practice, and has already caused various ordered
extent double accounting (fixed by the recent error handling patchset).
So this series will address the problem by:
- Refactor run_delalloc_nocow() to extract the NOCOW ordered extents
creation
To make later error handling a little simpler.
- Move ordered extents cleanup to where they got created
There are 3 call sites:
- cow_file_range()
This is the simplest one, as the recent fix makes it pretty straight
forward.
- nocow_one_range()
The new helper introduced to created ordered extents and extent maps
for NOCOW writes.
This is also pretty straightforward
- run_delalloc_nocow()
There are 3 different error cases that needs to adjust the ordered
extents cleanup range.
Qu Wenruo (2):
btrfs: extract the nocow ordered extent and extent map generation into
a helper
btrfs: move ordered extent cleanup to where they are allocated
fs/btrfs/inode.c | 188 +++++++++++++++++++++++++++--------------------
1 file changed, 107 insertions(+), 81 deletions(-)
--
2.47.1
next reply other threads:[~2025-01-13 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 9:42 Qu Wenruo [this message]
2025-01-13 9:42 ` [PATCH 1/2] btrfs: extract the nocow ordered extent and extent map generation into a helper Qu Wenruo
2025-02-06 0:39 ` Boris Burkov
2025-01-13 9:42 ` [PATCH 2/2] btrfs: move ordered extent cleanup to where they are allocated Qu Wenruo
2025-02-06 0:39 ` Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1736759698.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox