public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/3] btrfs: enhancement to pass generic/563
Date: Tue, 14 Jan 2025 20:22:26 +1030	[thread overview]
Message-ID: <cover.1736848277.git.wqu@suse.com> (raw)

The test case generic/563 on aarch64 with 64K page size and 4K fs block
size will fail with btrfs, but not EXT4 nor XFS.

The detailed reason is explained in the last patch, the TL;DR is that
btrfs is not handling block aligned buffered write in an optimized way
for subpage cases (block size < page size).

The first patch is a refactor in preparation for the new enhancement.
The second patch is to solve the possible deadlock which can only be
exposed by the final enhancement.

Eventually the last patch will enable the enhancement and pass the
generic/563.

This series used to be mixed into this series:
https://lore.kernel.org/linux-btrfs/cover.1732492421.git.wqu@suse.com/

But unfortunately the ordered extent double accounting fix is not
solving all problems.
And since all the ordered extents double accounting is properly fixed in
for-next, we can come back to the subpage enhancement and focus on it.

Qu Wenruo (3):
  btrfs: make btrfs_do_readpage() to do block-by-block read
  btrfs: avoid deadlock when reading a partial uptodate folio
  btrfs: allow buffered write to avoid full page read if it's block
    aligned

 fs/btrfs/defrag.c       |  2 +-
 fs/btrfs/direct-io.c    |  2 +-
 fs/btrfs/extent_io.c    | 44 +++++++++++----------------
 fs/btrfs/file.c         | 13 ++++----
 fs/btrfs/inode.c        |  6 ++--
 fs/btrfs/ordered-data.c | 67 ++++++++++++++++++++++++++++++++++++-----
 fs/btrfs/ordered-data.h |  8 +++--
 7 files changed, 94 insertions(+), 48 deletions(-)

-- 
2.48.0


             reply	other threads:[~2025-01-14  9:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14  9:52 Qu Wenruo [this message]
2025-01-14  9:52 ` [PATCH 1/3] btrfs: make btrfs_do_readpage() to do block-by-block read Qu Wenruo
2025-01-14  9:52 ` [PATCH 2/3] btrfs: avoid deadlock when reading a partial uptodate folio Qu Wenruo
2025-01-14  9:52 ` [PATCH 3/3] btrfs: allow buffered write to avoid full page read if it's block aligned Qu Wenruo
2025-01-28  1:30 ` [PATCH 0/3] btrfs: enhancement to pass generic/563 David Sterba
2025-02-09  5:18   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1736848277.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox