From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/3] btrfs: scrub: enhance freezing and signal handling
Date: Thu, 16 Oct 2025 15:02:28 +1030 [thread overview]
Message-ID: <cover.1760588662.git.wqu@suse.com> (raw)
It's a long known bug that when scrub/dev-replace is running, power
management suspension will time out and fail.
After more debugging and helps from Askar Safin, it turns out there are
at least 3 components involved:
- Process freezing
This is at the preparation for suspension, which requires all user
space processes (and some kthreads) to be frozen, which requires the
process return to user space.
Thus if the process (normally btrfs command) is falling into a long
running ioctl (like scrub/dev-replace) it will not be frozen thus
breaking the pm suspension.
This mean paused scrub is not feasible, as paused scrub will still
make the ioctl executing process trapped inside kernel space.
- Filesystem freezing
It's an optional behavior during pm suspension, previously I submitted
one patch detecting such situation, and so far it works as expected.
But this fs freezing is only optional, not yet default behavior of pm
suspension.
- Systemd slice freezing
This is the most complex part that I have not yet fully pinned down.
To address the first 2 problems, the series will:
- Add extra cancel/pause/removed bg checks for raid56 parity stripes
Mostly to reduce delay for RAID56 cases, and make the behavior more
consistent.
- Cancel the scrub if the fs/process is being frozen
- Cancel the scrub if there is a pending signal
For the systemd slice situation I have no idea how slice freezing is
done, but at least we should check pending signals (not only fatal
ones), which will align the behavior to relocation.
Qu Wenruo (3):
btrfs: scrub: add cancel/pause/removed bg checks for raid56 parity
stripes
btrfs: scrub: cancel the run if the process or fs is being frozen
btrfs: scrub: cancel the run if there is a pending signal
fs/btrfs/scrub.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
--
2.51.0
next reply other threads:[~2025-10-16 4:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 4:32 Qu Wenruo [this message]
2025-10-16 4:32 ` [PATCH 1/3] btrfs: scrub: add cancel/pause/removed bg checks for raid56 parity stripes Qu Wenruo
2025-10-16 7:55 ` Filipe Manana
2025-10-16 4:32 ` [PATCH 2/3] btrfs: scrub: cancel the run if the process or fs is being frozen Qu Wenruo
2025-10-16 7:51 ` Filipe Manana
2025-10-16 8:00 ` Qu Wenruo
2025-10-16 16:42 ` David Sterba
2025-10-16 20:35 ` Qu Wenruo
2025-10-17 7:54 ` Qu Wenruo
2025-10-17 17:00 ` David Sterba
2025-10-17 20:49 ` Qu Wenruo
2025-10-16 4:32 ` [PATCH 3/3] btrfs: scrub: cancel the run if there is a pending signal Qu Wenruo
2025-10-16 7:58 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1760588662.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox