public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 00/19] btrfs: fix a return value and remove pointless labels and gotos
Date: Wed, 21 Jan 2026 11:13:34 +0000	[thread overview]
Message-ID: <cover.1768993725.git.fdmanana@suse.com> (raw)

From: Filipe Manana <fdmanana@suse.com>

Remove pointless labels and gotos that can be replaced with a single
"return ret" or "return -SOMEERROR", making the code shorter and more
straighforward to follow and to not leave such examples for people to
copy and keep repeating it. The first patch fixes a bug in an error
path where we can end up returning success (0) instead of an error.

Filipe Manana (19):
  btrfs: qgroup: return correct error when deleting qgroup relation item
  btrfs: remove pointless out labels from ioctl.c
  btrfs: remove pointless out labels from send.c
  btrfs: remove pointless out labels from qgroup.c
  btrfs: remove pointless out labels from disk-io.c
  btrfs: remove pointless out labels from extent-tree.c
  btrfs: remove pointless out labels from free-space-cache.c
  btrfs: remove pointless out labels from inode.c
  btrfs: remove pointless out labels from uuid-tree.c
  btrfs: remove out label in load_extent_tree_free()
  btrfs: remove out_failed label in find_lock_delalloc_range()
  btrfs: remove out label in btrfs_csum_file_blocks()
  btrfs: remove out label in btrfs_mark_extent_written()
  btrfs: remove out label in lzo_decompress()
  btrfs: remove out label in scrub_find_fill_first_stripe()
  btrfs: remove out label in finish_verity()
  btrfs: remove out label in btrfs_check_rw_degradable()
  btrfs: remove out label in btrfs_init_space_info()
  btrfs: remove out label in btrfs_wait_for_commit()

 fs/btrfs/block-group.c      | 10 +++---
 fs/btrfs/disk-io.c          | 54 ++++++++++++------------------
 fs/btrfs/extent-tree.c      | 24 ++++++-------
 fs/btrfs/extent_io.c        |  5 ++-
 fs/btrfs/file-item.c        | 16 ++++-----
 fs/btrfs/file.c             | 30 ++++++++---------
 fs/btrfs/free-space-cache.c | 31 +++++++----------
 fs/btrfs/inode.c            | 21 +++++-------
 fs/btrfs/ioctl.c            | 40 +++++++++-------------
 fs/btrfs/lzo.c              | 15 ++++-----
 fs/btrfs/qgroup.c           | 22 +++++-------
 fs/btrfs/scrub.c            |  8 ++---
 fs/btrfs/send.c             | 67 ++++++++++++++++---------------------
 fs/btrfs/space-info.c       | 13 ++++---
 fs/btrfs/transaction.c      |  9 ++---
 fs/btrfs/uuid-tree.c        | 16 ++++-----
 fs/btrfs/verity.c           | 13 +++----
 fs/btrfs/volumes.c          | 12 +++----
 18 files changed, 173 insertions(+), 233 deletions(-)

-- 
2.47.2


             reply	other threads:[~2026-01-21 11:13 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 11:13 fdmanana [this message]
2026-01-21 11:13 ` [PATCH 01/19] btrfs: qgroup: return correct error when deleting qgroup relation item fdmanana
2026-01-21 11:13 ` [PATCH 02/19] btrfs: remove pointless out labels from ioctl.c fdmanana
2026-01-21 11:13 ` [PATCH 03/19] btrfs: remove pointless out labels from send.c fdmanana
2026-01-21 15:01   ` Johannes Thumshirn
2026-01-21 15:04   ` Johannes Thumshirn
2026-01-21 15:23     ` Filipe Manana
2026-01-21 17:01       ` Johannes Thumshirn
2026-01-21 11:13 ` [PATCH 04/19] btrfs: remove pointless out labels from qgroup.c fdmanana
2026-01-21 11:13 ` [PATCH 05/19] btrfs: remove pointless out labels from disk-io.c fdmanana
2026-01-21 11:13 ` [PATCH 06/19] btrfs: remove pointless out labels from extent-tree.c fdmanana
2026-01-21 11:13 ` [PATCH 07/19] btrfs: remove pointless out labels from free-space-cache.c fdmanana
2026-01-21 11:13 ` [PATCH 08/19] btrfs: remove pointless out labels from inode.c fdmanana
2026-01-21 11:13 ` [PATCH 09/19] btrfs: remove pointless out labels from uuid-tree.c fdmanana
2026-01-21 11:13 ` [PATCH 10/19] btrfs: remove out label in load_extent_tree_free() fdmanana
2026-01-21 11:13 ` [PATCH 11/19] btrfs: remove out_failed label in find_lock_delalloc_range() fdmanana
2026-01-21 11:13 ` [PATCH 12/19] btrfs: remove out label in btrfs_csum_file_blocks() fdmanana
2026-01-21 11:13 ` [PATCH 13/19] btrfs: remove out label in btrfs_mark_extent_written() fdmanana
2026-01-21 11:13 ` [PATCH 14/19] btrfs: remove out label in lzo_decompress() fdmanana
2026-01-21 11:13 ` [PATCH 15/19] btrfs: remove out label in scrub_find_fill_first_stripe() fdmanana
2026-01-21 11:13 ` [PATCH 16/19] btrfs: remove out label in finish_verity() fdmanana
2026-02-08 16:10   ` Chris Mason
2026-02-08 18:37     ` Filipe Manana
2026-01-21 11:13 ` [PATCH 17/19] btrfs: remove out label in btrfs_check_rw_degradable() fdmanana
2026-01-21 11:13 ` [PATCH 18/19] btrfs: remove out label in btrfs_init_space_info() fdmanana
2026-01-21 11:13 ` [PATCH 19/19] btrfs: remove out label in btrfs_wait_for_commit() fdmanana
2026-01-21 16:30 ` [PATCH v2 00/19] btrfs: fix a return value and remove pointless labels and gotos fdmanana
2026-01-21 16:30   ` [PATCH v2 01/19] btrfs: qgroup: return correct error when deleting qgroup relation item fdmanana
2026-01-21 16:30   ` [PATCH v2 02/19] btrfs: remove pointless out labels from ioctl.c fdmanana
2026-01-21 16:30   ` [PATCH v2 03/19] btrfs: remove pointless out labels from send.c fdmanana
2026-01-21 16:30   ` [PATCH v2 04/19] btrfs: remove pointless out labels from qgroup.c fdmanana
2026-01-21 16:30   ` [PATCH v2 05/19] btrfs: remove pointless out labels from disk-io.c fdmanana
2026-01-21 16:30   ` [PATCH v2 06/19] btrfs: remove pointless out labels from extent-tree.c fdmanana
2026-01-21 16:30   ` [PATCH v2 07/19] btrfs: remove pointless out labels from free-space-cache.c fdmanana
2026-01-21 16:30   ` [PATCH v2 08/19] btrfs: remove pointless out labels from inode.c fdmanana
2026-01-21 16:30   ` [PATCH v2 09/19] btrfs: remove pointless out labels from uuid-tree.c fdmanana
2026-01-21 16:30   ` [PATCH v2 10/19] btrfs: remove out label in load_extent_tree_free() fdmanana
2026-01-21 16:30   ` [PATCH v2 11/19] btrfs: remove out_failed label in find_lock_delalloc_range() fdmanana
2026-01-21 16:30   ` [PATCH v2 12/19] btrfs: remove out label in btrfs_csum_file_blocks() fdmanana
2026-01-21 16:30   ` [PATCH v2 13/19] btrfs: remove out label in btrfs_mark_extent_written() fdmanana
2026-01-21 16:30   ` [PATCH v2 14/19] btrfs: remove out label in lzo_decompress() fdmanana
2026-01-21 16:30   ` [PATCH v2 15/19] btrfs: remove out label in scrub_find_fill_first_stripe() fdmanana
2026-01-21 16:30   ` [PATCH v2 16/19] btrfs: remove out label in finish_verity() fdmanana
2026-01-21 16:30   ` [PATCH v2 17/19] btrfs: remove out label in btrfs_check_rw_degradable() fdmanana
2026-01-21 16:30   ` [PATCH v2 18/19] btrfs: remove out label in btrfs_init_space_info() fdmanana
2026-01-21 16:30   ` [PATCH v2 19/19] btrfs: remove out label in btrfs_wait_for_commit() fdmanana
2026-01-22 10:45   ` [PATCH v2 00/19] btrfs: fix a return value and remove pointless labels and gotos Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1768993725.git.fdmanana@suse.com \
    --to=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox