Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/4] btrfs: dev-replace: replace_task related cleanup
Date: Mon, 24 Aug 2026 14:04:04 +0930	[thread overview]
Message-ID: <cover.1787545216.git.wqu@suse.com> (raw)

[CHANGELOG]
v3:
- More cleanup patches for dev-replace
  Most newer ones are minor, e.g. changing the message and its timing.
  But the error handling inside btrfs_dev_replace_finishing() is
  important for later replace_task cleanup.

- Directly modify replace_task when the replace is suspended
  We do not need any extra lock, since the only reader is accessing
  replace_task without lock anyway.

We have 4 errors paths that do not properly reset replace_task to NULL
after the replace is cancelled/finished/suspended.

This is reported by Sashiko.

And since we're here, also do extra cleanup related to dev-replace error
message and its timing.

Qu Wenruo (4):
  btrfs: dev-replace: fix the incorrect error message
  btrfs: dev-replace: concentrate all messages into
    btrfs_dev_replace_finishing()
  btrfs: dev-replace: fix the error handling in
    btrfs_dev_replace_finishing()
  btrfs: dev-replace: properly cleanup replace_task

 fs/btrfs/dev-replace.c | 79 +++++++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 35 deletions(-)

-- 
2.55.0


             reply	other threads:[~2026-08-24  4:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24  4:34 Qu Wenruo [this message]
2026-08-24  4:34 ` [PATCH v3 1/4] btrfs: dev-replace: fix the incorrect error message Qu Wenruo
2026-08-24  4:34 ` [PATCH v3 2/4] btrfs: dev-replace: concentrate all messages into btrfs_dev_replace_finishing() Qu Wenruo
2026-08-24  4:34 ` [PATCH v3 3/4] btrfs: dev-replace: fix the error handling in btrfs_dev_replace_finishing() Qu Wenruo
2026-08-24 17:11   ` David Sterba
2026-08-24  4:34 ` [PATCH v3 4/4] btrfs: dev-replace: properly cleanup replace_task Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1787545216.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox