Re: [PATCH] btrfs: add helper to exit_btrfs_fs

[Anand Jain <anand.jain@oracle.com>]

On 18/10/2022 01:59, David Sterba wrote:
> On Fri, Oct 14, 2022 at 08:17:26PM +0800, Anand Jain wrote:
>> The module exit function exit_btrfs_fs() is duplicating a section of code
>> in init_btrfs_fs(). So add a helper function to remove the duplicate code.
>> Also, remove the comment about the function's .text section, which
>> doesn't make sense.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> David,
>>   This patch is on top of Qu's patch on the mailing list.
>>     btrfs: make btrfs module init/exit match their sequence
>>
>>   This patch passed, make mrproper, compile with defconfig and Oracle Linux config.
>>   and, Module load/unload.
>>   I suggested this change in the review comment, but it wasn't going anywhere.
>>   Instead, I found sending a patch is more productive. Please, keep my SOB.
> 
> So there's the for() { } duplication but we need to be careful about the
> sections. Can we rather use some inlining tricks to force the common
> code to be inlined and avoid dealing with the sections explicitly? Eg.
> using __always_inline.

Yeah, must avoid section mismatch, explicitly making
it inline is better. Sent v2. (sorry for the delay in response).

Thanks, Anand