From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, josef@toxicpanda.com
Subject: Re: [PATCH 4/5] btrfs: scrub_checksum_tree_block() drop its function declaration
Date: Thu, 25 Feb 2021 09:21:31 +0800 [thread overview]
Message-ID: <d0f695b1-70b9-99d1-9b45-c5b21bc07b42@oracle.com> (raw)
In-Reply-To: <20210212143639.GJ1993@twin.jikos.cz>
On 12/02/2021 22:36, David Sterba wrote:
> On Wed, Feb 10, 2021 at 09:25:18PM -0800, Anand Jain wrote:
>> Move the static function scrub_checksum_tree_block() before its use in
>> the scrub.c, and drop its declaration.
>>
>> No functional changes.
>
> We've rejected patches that move static function within one file unless
> there's another reason for it other than removing the prototype.
Ok.
Patches 1-3 aren't of this type. I suppose they will be integrated?
Thanks, Anand
next prev parent reply other threads:[~2021-02-25 1:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 5:25 [PATCH 0/5] cleanups btrfs_extent_readonly() and scrub, part1 Anand Jain
2021-02-11 5:25 ` [PATCH 1/5] btrfs: make btrfs_extent_readonly() static Anand Jain
2021-02-11 5:25 ` [PATCH 2/5] btrfs: btrfs_extent_readonly() change return type to bool Anand Jain
2021-02-11 13:00 ` Johannes Thumshirn
2021-02-11 5:25 ` [PATCH 3/5] btrfs: scrub drop few function declarations Anand Jain
2021-02-11 13:27 ` Johannes Thumshirn
2021-02-11 5:25 ` [PATCH 4/5] btrfs: scrub_checksum_tree_block() drop its function declaration Anand Jain
2021-02-11 13:28 ` Johannes Thumshirn
2021-02-12 14:36 ` David Sterba
2021-02-25 1:21 ` Anand Jain [this message]
2021-02-25 16:16 ` David Sterba
2021-02-11 5:25 ` [PATCH 5/5] btrfs: scrub_checksum_data() " Anand Jain
2021-02-11 13:30 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f695b1-70b9-99d1-9b45-c5b21bc07b42@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).