From: Markus Elfring <Markus.Elfring@web.de>
To: Kunwu Chan <chentao@kylinos.cn>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Chris Mason <clm@fb.com>,
David Sterba <dsterba@suse.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [v2] btrfs: Simplify the allocation of slab caches in btrfs_delayed_inode_init
Date: Thu, 1 Feb 2024 14:28:16 +0100 [thread overview]
Message-ID: <d14e1d0f-7463-45ce-a25e-2d80f7996934@web.de> (raw)
In-Reply-To: <20240201084406.202446-1-chentao@kylinos.cn>
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> Make the code cleaner and more readable.
* Please replace the word “new” by a reference to the commit 8eb8284b412906181357c2b0110d879d5af95e52
("usercopy: Prepare for usercopy whitelisting").
See also related background information from 2017-06-10.
* How does your response fit to the repetition of improvable change descriptions?
Example:
[PATCH] btrfs: Simplify the allocation of slab caches in btrfs_transaction_init
https://lore.kernel.org/lkml/20240201093554.208092-1-chentao@kylinos.cn/
https://lkml.org/lkml/2024/2/1/387
* Would you like to group similar source code transformations
into patch series?
Regards,
Markus
next prev parent reply other threads:[~2024-02-01 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 8:44 [PATCH v2] btrfs: Simplify the allocation of slab caches in btrfs_delayed_inode_init Kunwu Chan
2024-02-01 13:28 ` Markus Elfring [this message]
2024-02-05 16:04 ` David Sterba
2024-02-19 9:00 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d14e1d0f-7463-45ce-a25e-2d80f7996934@web.de \
--to=markus.elfring@web.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=chentao@kylinos.cn \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox