From: Josef Bacik <josef@toxicpanda.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, Greed Rong <greedrong@gmail.com>
Subject: Re: [PATCH 4/4] btrfs: free anon_dev earlier to prevent exhausting anonymous block device pool
Date: Tue, 16 Jun 2020 19:31:07 -0400 [thread overview]
Message-ID: <d1be2720-afa0-80a7-6472-6f7fe05feaf9@toxicpanda.com> (raw)
In-Reply-To: <20200616224840.GI27795@twin.jikos.cz>
On 6/16/20 6:48 PM, David Sterba wrote:
> On Tue, Jun 16, 2020 at 03:23:03PM -0400, Josef Bacik wrote:
>>> By freeing it earlier we reclaim the anon_dev quicker, hopefully to
>>> reduce the chance of exhausting the pool.
>>
>> Why isn't this happening as part of the root teardown once all the references to
>> it are gone? Thanks,
>
> This is where it happens now and is correct. The problem is that deleted
> subvolumes keep the id allocated until they are cleaned up, ie. all the
> dead roots consume the id though we don't need it anymore. Creating and
> deleting snapshots at large will produce a long list of dead subvolumes.
> THis patch will return the ids at the earlies possible moment so they
> can get reused.
>
Oh ok I misread, we're doing it earlier on purpose. Alright that's fine, you
can add
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2020-06-16 23:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 2:17 [PATCH 0/4] btrfs: workaround exhausted anonymous block device pool Qu Wenruo
2020-06-16 2:17 ` [PATCH 1/4] btrfs: disk-io: don't allocate anonymous block device for user invisible roots Qu Wenruo
2020-06-16 19:21 ` Josef Bacik
2020-06-16 2:17 ` [PATCH 2/4] btrfs: detect uninitialized btrfs_root::anon_dev for user visible subvolumes Qu Wenruo
2020-06-16 19:25 ` Josef Bacik
2020-06-16 22:49 ` Qu Wenruo
2020-06-16 23:32 ` Josef Bacik
2020-06-16 23:49 ` Qu Wenruo
2020-06-17 11:31 ` David Sterba
2020-06-17 13:37 ` Josef Bacik
2020-06-17 23:39 ` Qu Wenruo
2020-06-16 2:17 ` [PATCH 3/4] btrfs: preallocate anon_dev for subvolume and snapshot creation Qu Wenruo
2020-06-16 15:10 ` David Sterba
2020-06-16 22:54 ` Qu Wenruo
2020-07-01 3:25 ` Qu Wenruo
2020-07-01 17:39 ` David Sterba
2020-07-01 23:56 ` Qu Wenruo
2020-07-02 16:08 ` David Sterba
2020-07-02 23:46 ` David Sterba
2020-07-03 5:19 ` Qu Wenruo
2020-07-03 12:29 ` David Sterba
2020-07-03 12:39 ` Qu Wenruo
2020-06-16 2:17 ` [PATCH 4/4] btrfs: free anon_dev earlier to prevent exhausting anonymous block device pool Qu Wenruo
2020-06-16 19:23 ` Josef Bacik
2020-06-16 22:48 ` David Sterba
2020-06-16 23:31 ` Josef Bacik [this message]
2020-06-30 14:14 ` [PATCH 0/4] btrfs: workaround exhausted " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1be2720-afa0-80a7-6472-6f7fe05feaf9@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=dsterba@suse.cz \
--cc=greedrong@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox