public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell Haley <yumpusamongus@gmail.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Subject: Re: BTRFS corruption after conversion to block group tree
Date: Sat, 2 Dec 2023 02:04:45 -0600	[thread overview]
Message-ID: <d1db5758-35d1-4737-b69d-06473cc46e86@gmail.com> (raw)
In-Reply-To: <bae5e86b-d215-4984-95f2-4f24a8ee6bd9@gmx.com>



On 12/2/23 00:43, Qu Wenruo wrote:
> 
> 
> On 2023/12/2 16:43, Russell Haley wrote:
>> To be clear, there is no reason to be suspicious of the other disk that
>> was converted to block group tree and has passed a scrub after
>> rebooting? It should be safe to mount that one read-write again?
> 
> Scrub is only checksum verification, no comprehensive extent tree
> cross-check like `btrfs check`.
> 
> If we really screwed up the block group tree conversion, btrfs check
> should be able to expose it.
> 
> Thus that's why I'm going to add "btrfs check" runs before and after
> block group tree conversion.
> 
> Just remember, scrub is never as good as "btrfs check".

Thanks. `btrfs check` passed too, so I've removed `ro` from fstab.

  reply	other threads:[~2023-12-02  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 11:46 BTRFS corruption after conversion to block group tree Russell Haley
2023-12-01 20:09 ` Qu Wenruo
2023-12-02  2:45   ` Russell Haley
2023-12-02  4:13     ` Qu Wenruo
2023-12-02  4:25       ` Qu Wenruo
2023-12-02  6:13         ` Russell Haley
2023-12-02  6:43           ` Qu Wenruo
2023-12-02  8:04             ` Russell Haley [this message]
2023-12-02  9:00               ` Qu Wenruo
2023-12-03 12:05             ` Russell Haley
2023-12-03 12:16               ` Russell Haley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1db5758-35d1-4737-b69d-06473cc46e86@gmail.com \
    --to=yumpusamongus@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox