From: Qu Wenruo <wqu@suse.com>
To: Guanjie Chen <jk.chen1095@gmail.com>
Cc: clm@fb.com, dsterba@suse.com, fdmanana@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: free qgroup configuration when quota enable fails
Date: Sat, 15 Aug 2026 17:33:28 +0930 [thread overview]
Message-ID: <d239645a-b291-4fe9-b256-f0be849c875a@suse.com> (raw)
In-Reply-To: <20260815064503.67385-1-jk.chen1095@gmail.com>
在 2026/8/15 16:14, Guanjie Chen 写道:
> Hi Qu,
>
> Thanks for the review.
>
> I agree the error path should be reversed, even though btrfs_free_qgroup_config() has defensive checks so it won't UAF. But this isn't a one-liner – maybe we can refactor the whole init/cleanup flow later and fix it properly.
>
> As for contributing: I know there's been lots of LLM noise lately, and I don't want to add to it. I've been studying btrfs for about 2~3 years now. For my next patch, would it help if I clearly explain the root cause, my reasoning, and the solution in the commit message or cover letter? I'd like to make review smoother.
I don't care, the policy is there, and all active developers are
following it:
https://docs.kernel.org/process/coding-assistants.html
I see no point why you want to be special and do not disclose whether
you have used LLM, unless you have something to hide and then I have all
reasons to question your motivation.
Even well known developers are using LLM actively, e.g:
https://lore.kernel.org/linux-btrfs/20260811-btrfs-enomem-v3-0-46a993fc3fe5@kernel.org/
https://lore.kernel.org/linux-btrfs/69d0043e0f6a3d17048dfde857127ab0bf331154.1785190866.git.boris@bur.io/
And of course myself:
https://lore.kernel.org/linux-btrfs/61fd5ab4b532ba3a7915dc629339db230cccd52f.1786007917.git.wqu@suse.com/
It's very simple, if you used LLM to analyze/fix the bug, then just
disclose it.
>
> Thanks again for your time.
>
> Best,
> Guanjie
next prev parent reply other threads:[~2026-08-15 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 11:22 [PATCH] btrfs: free qgroup configuration when quota enable fails Guanjie Chen
2026-08-14 11:49 ` Qu Wenruo
2026-08-14 12:30 ` Guanjie Chen
2026-08-14 22:13 ` Qu Wenruo
2026-08-15 6:44 ` Guanjie Chen
2026-08-15 8:03 ` Qu Wenruo [this message]
[not found] <d239645a-b291-4fe9-b256-f0be849c875a@suse.com@suse.com>
2026-08-15 9:00 ` Guanjie Chen
2026-08-15 9:08 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d239645a-b291-4fe9-b256-f0be849c875a@suse.com \
--to=wqu@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=jk.chen1095@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox