From: Nikolay Borisov <nborisov@suse.com>
To: dsterba@suse.cz, Qu Wenruo <quwenruo.btrfs@gmx.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs-progs: Remove deprecated btrfs-zero-log standalone tool
Date: Thu, 22 Mar 2018 15:37:43 +0200 [thread overview]
Message-ID: <d29ba513-7a03-66ec-61d3-28ee07a80b83@suse.com> (raw)
In-Reply-To: <20180322133140.GY6955@twin.jikos.cz>
On 22.03.2018 15:31, David Sterba wrote:
> On Thu, Mar 22, 2018 at 09:29:46PM +0800, Qu Wenruo wrote:
>>
>>
>> On 2018年03月22日 21:18, Nikolay Borisov wrote:
>>> Its function has been subsumed by "btrfs rescue zero-log". Remove its
>>> source file and adjust make/tests soruces accordingly.
>>
>> Despite of the lack of sob tag, it looks good.
>>
>>> ---
>>> Makefile | 4 +-
>>> btrfs-zero-log.c | 78 -----------------------------------
>>> tests/misc-tests.sh | 1 -
>>> tests/misc-tests/003-zero-log/test.sh | 6 +--
>>
>> What about updating .gitignore to remove btrfs-zero-log?
>
> Not just that, here's the whole checklist:
>
> https://github.com/kdave/btrfs-progs/issues/97
I saw the checklist but wasn't sure about the "document removal" bit.
>
prev parent reply other threads:[~2018-03-22 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 13:18 [PATCH 1/3] btrfs-progs: Remove deprecated btrfs-zero-log standalone tool Nikolay Borisov
2018-03-22 13:18 ` [PATCH 2/3] btrfs-progs: Remove deprecated btrfs-show-super Nikolay Borisov
2018-03-22 13:34 ` Qu Wenruo
2018-03-22 13:18 ` [PATCH 3/3] btrfs-progs: Remove deprecated btrfs-calc-size tool Nikolay Borisov
2018-03-22 13:29 ` [PATCH 1/3] btrfs-progs: Remove deprecated btrfs-zero-log standalone tool Qu Wenruo
2018-03-22 13:31 ` David Sterba
2018-03-22 13:37 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d29ba513-7a03-66ec-61d3-28ee07a80b83@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).