From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: xfstests is rather unhappy on current for-next
Date: Wed, 24 Aug 2022 08:06:45 +0800 [thread overview]
Message-ID: <d3836d12-641a-a332-12bf-7aff815f1850@gmx.com> (raw)
In-Reply-To: <c2c1f526-d183-8ade-1439-71d1e23f6ea9@gmx.com>
On 2022/8/24 07:08, Qu Wenruo wrote:
>
>
> On 2022/8/24 00:46, Christoph Hellwig wrote:
>> On Tue, Aug 23, 2022 at 09:19:38AM -0700, Christoph Hellwig wrote:
>>> default options on x86-64 with a five-device spare pool gets
>>> unhappy in the kobject code when running btrfs/017, and the
>>> xfstest run then hangs:
>>
>> I've bisect this to:
>>
>> [80e96a54dd6993d6de0dc81285c02c709487808a] btrfs: sysfs: introduce
>> qgroup global attribute groups
>>
>
> Thanks, will take a look into this, I guess some code base is already
> out of date.
Root cause is in that commit, I'm using kmalloc() for fs_info->qgroups_kobj.
Not sure why my previous runs didn't trigger the problem...
Simply change that kmalloc() to kzalloc() can fix it.
Will do more testing to make sure the seemingly untouched patchset is
still doing its work correctly.
Thanks,
Qu
>
> Thanks,
> Qu
>
>>
>>>
>>> [ 85.716152] run fstests btrfs/017 at 2022-08-23 16:15:45
>>> [ 87.843179] BTRFS: device fsid
>>> 439db035-2c01-4c8e-9217-40d0accfd536 devid 1 transid 6)
>>> [ 87.921800] BTRFS info (device vdc): using crc32c (crc32c-generic)
>>> checksum algorithm
>>> [ 87.923465] BTRFS info (device vdc): using free space tree
>>> [ 87.937642] BTRFS info (device vdc): checking UUID tree
>>> [ 88.046021] kobject (ffff888104755140): tried to init an
>>> initialized object, somethin.
>>> [ 88.048050] CPU: 0 PID: 7250 Comm: btrfs Not tainted
>>> 6.0.0-rc2-block+ #2218
>>> [ 88.049364] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
>>> BIOS 1.14.0-2 04/04
>>> [ 88.050906] Call Trace:
>>> [ 88.051381] <TASK>
>>> [ 88.051798] dump_stack_lvl+0x56/0x6f
>>> [ 88.052506] kobject_init.cold+0x31/0x3f
>>> [ 88.053251] kobject_init_and_add+0x35/0xa0
>>> [ 88.054022] ? rcu_read_lock_sched_held+0x3a/0x60
>>> [ 88.054864] ? trace_kmalloc+0x29/0xd0
>>> [ 88.055537] ? kmem_cache_alloc_trace+0x1ee/0x340
>>> [ 88.056376] btrfs_sysfs_add_qgroups+0x87/0x100
>>> [ 88.057192] btrfs_quota_enable+0xc6/0x830
>>> [ 88.057930] ? trace_kmalloc+0x29/0xd0
>>> [ 88.058598] ? __kmalloc_track_caller+0x20f/0x3b0
>>> [ 88.059431] ? btrfs_ioctl+0x251f/0x35c0
>>> [ 88.060138] btrfs_ioctl+0x2e06/0x35c0
>>> [ 88.060818] ? find_held_lock+0x2b/0x80
>>> [ 88.061519] ? lock_release+0x147/0x2f0
>>> [ 88.062217] ? __x64_sys_ioctl+0x7b/0xb0
>>> [ 88.062919] __x64_sys_ioctl+0x7b/0xb0
>>> [ 88.063592] do_syscall_64+0x35/0x80
>>> [ 88.064245] entry_SYSCALL_64_after_hwframe+0x63/0xcd
>>> [ 88.065146] RIP: 0033:0x7f0240ada397
>>> [ 88.065912] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff
>>> ff ff 5b 5d 4c 89 e8
>>> [ 88.069908] RSP: 002b:00007fff156c90c8 EFLAGS: 00000202 ORIG_RAX:
>>> 0000000000000010
>>> [ 88.071473] RAX: ffffffffffffffda RBX: 0000000000000000 RCX:
>>> 00007f0240ada397
>>> [ 88.072988] RDX: 00007fff156c90e0 RSI: 00000000c0109428 RDI:
>>> 0000000000000003
>>> [ 88.074391] RBP: 0000000000000003 R08: 000056165e61c2a0 R09:
>>> 00007f0240bb8c00
>>> [ 88.075788] R10: fffffffffffff248 R11: 0000000000000202 R12:
>>> 00007fff156c9dfa
>>> [ 88.077433] R13: 0000000000000001 R14: 000056165cc0008d R15:
>>> 00007fff156c9288
>>> [ 88.079003] </TASK>
>>> [ 88.080327] general protection fault, probably for non-canonical
>>> address 0x1ad998badaI
>>> [ 88.082664] CPU: 1 PID: 7250 Comm: btrfs Not tainted
>>> 6.0.0-rc2-block+ #2218
>>> [ 88.083949] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
>>> BIOS 1.14.0-2 04/04
>>> [ 88.085488] RIP: 0010:kfree+0x6e/0x550
>>> [ 88.086159] Code: 01 d8 0f 82 dd 04 00 00 49 bc 00 00 00 80 7f 77
>>> 00 00 49 01 c4 48 b4
>>> [ 88.089383] RSP: 0018:ffffc900036d7c58 EFLAGS: 00010203
>>> [ 88.090304] RAX: ffffea0000000000 RBX: 6b6b6b6b6b6b6b6b RCX:
>>> 0000000000000001
>>> [ 88.091550] RDX: 0000000000000000 RSI: ffffffff82fbd87b RDI:
>>> ffffffff830a6076
>>> [ 88.092793] RBP: ffffc900036d7c90 R08: ffffffff83085f05 R09:
>>> 0000000000000001
>>> [ 88.094042] R10: 0000000000000304 R11: ffffffff83a3b9e0 R12:
>>> 01ad998badadad80
>>> [ 88.095345] R13: ffff888104755140 R14: ffff88810d375910 R15:
>>> ffff88810d3b4000
>>> [ 88.096588] FS: 00007f02409e8d40(0000) GS:ffff88813bd00000(0000)
>>> knlGS:00000000000000
>>> [ 88.098002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> [ 88.099010] CR2: 000055f382527900 CR3: 000000010d1da000 CR4:
>>> 00000000000006e0
>>> [ 88.100254] Call Trace:
>>> [ 88.100699] <TASK>
>>> [ 88.101088] kobject_set_name_vargs+0x6f/0x90
>>> [ 88.101950] kobject_init_and_add+0x5d/0xa0
>>> [ 88.102697] ? trace_kmalloc+0x29/0xd0
>>> [ 88.103366] ? kmem_cache_alloc_trace+0x1ee/0x340
>>> [ 88.104256] btrfs_sysfs_add_qgroups+0x87/0x100
>>> [ 88.105340] btrfs_quota_enable+0xc6/0x830
>>> [ 88.106076] ? trace_kmalloc+0x29/0xd0
>>> [ 88.106748] ? __kmalloc_track_caller+0x20f/0x3b0
>>> [ 88.107584] ? btrfs_ioctl+0x251f/0x35c0
>>> [ 88.108282] btrfs_ioctl+0x2e06/0x35c0
>>> [ 88.108953] ? find_held_lock+0x2b/0x80
>>> [ 88.109654] ? lock_release+0x147/0x2f0
>>> [ 88.110340] ? __x64_sys_ioctl+0x7b/0xb0
>>> [ 88.111038] __x64_sys_ioctl+0x7b/0xb0
>>> [ 88.111724] do_syscall_64+0x35/0x80
>>> [ 88.112368] entry_SYSCALL_64_after_hwframe+0x63/0xcd
>>> [ 88.113263] RIP: 0033:0x7f0240ada397
>>> [ 88.113913] Code: 3c 1c e8 1c ff ff ff 85 c0 79 87 49 c7 c4 ff ff
>>> ff ff 5b 5d 4c 89 e8
>>> [ 88.117319] RSP: 002b:00007fff156c90c8 EFLAGS: 00000202 ORIG_RAX:
>>> 0000000000000010
>>> [ 88.118657] RAX: ffffffffffffffda RBX: 0000000000000000 RCX:
>>> 00007f0240ada397
>>> [ 88.119898] RDX: 00007fff156c90e0 RSI: 00000000c0109428 RDI:
>>> 0000000000000003
>>> [ 88.121137] RBP: 0000000000000003 R08: 000056165e61c2a0 R09:
>>> 00007f0240bb8c00
>>> [ 88.122404] R10: fffffffffffff248 R11: 0000000000000202 R12:
>>> 00007fff156c9dfa
>>> [ 88.123648] R13: 0000000000000001 R14: 000056165cc0008d R15:
>>> 00007fff156c9288
>>> [ 88.124895] </TASK>
>>> [ 88.125298] Modules linked in:
>>> [ 88.126308] ---[ end trace 0000000000000000 ]---
>>>
>>>
>>>
>>>
>>>
>> ---end quoted text---
prev parent reply other threads:[~2022-08-24 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:19 xfstests is rather unhappy on curret for-next Christoph Hellwig
2022-08-23 16:46 ` xfstests is rather unhappy on current for-next Christoph Hellwig
2022-08-23 19:38 ` David Sterba
2022-08-23 23:08 ` Qu Wenruo
2022-08-24 0:06 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3836d12-641a-a332-12bf-7aff815f1850@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox