linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: convert-tests: skip 022 if no reiserfs support
@ 2022-10-04  5:35 Qu Wenruo
  0 siblings, 0 replies; only message in thread
From: Qu Wenruo @ 2022-10-04  5:35 UTC (permalink / raw)
  To: linux-btrfs

[BUG]
If no reiserfs is enabled, convert-test/022 will fail like this:

    [TEST]   convert-tests.sh
    WARNING: reiserfs filesystem not listed in /proc/filesystems, some tests might be skipped
    [TEST/conv]   022-reiserfs-parent-ref
    Failed system wide prerequisities: mkreiserfs
    test failed for case 022-reiserfs-parent-ref

[CAUSE]
That test case just continue without checking if the kernel even has
reiserfs support.

[FIX]
Skip the test if no kernel support for reiserfs, just like convert/010.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 tests/convert-tests/022-reiserfs-parent-ref/test.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/convert-tests/022-reiserfs-parent-ref/test.sh b/tests/convert-tests/022-reiserfs-parent-ref/test.sh
index 66aaff7b6502..3d8817b91b0a 100755
--- a/tests/convert-tests/022-reiserfs-parent-ref/test.sh
+++ b/tests/convert-tests/022-reiserfs-parent-ref/test.sh
@@ -3,6 +3,10 @@
 
 source "$TEST_TOP/common"
 
+if ! check_kernel_support_reiserfs >/dev/null; then
+	_not_run "no reiserfs support"
+fi
+
 setup_root_helper
 prepare_test_dev
 check_global_prereq mkreiserfs
-- 
2.37.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-04  5:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-04  5:35 [PATCH] btrfs-progs: convert-tests: skip 022 if no reiserfs support Qu Wenruo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).