From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76C0D388E6C; Wed, 15 Apr 2026 06:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776234030; cv=none; b=VCvAkfhQAaTcTNv/taiqmxBrS67PnD7jLsrdJkWzW1g5d3hHYJnZyRBQEHPfL0n50zNjtUD/Apw/xbKO+CqqWPDVESiBJZSlfLFi1Z0zVIXu2ob4gogumLKrSAZ8Bwaaf/DDNl1ILznc649E9YFFCxVnzyfgY+WHqL1o6ZbkJK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776234030; c=relaxed/simple; bh=TLQ9jsWmwrM4o1MP8zC1FivP5SErP8sIZiMfNkNJxdQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iKMkh5eU2OTM8nOysbfe8UYnMop65FgxCI75Q35ad4V/mISyJdh0hJDL5xlk9xZmzfxjRR8ZDIc6xbuY+wvEXHXsbKCcfIuce/7PH2RdwbrlBrzyL2PwBabgOc3wo2oG7/zCWJdB6wCqx4uZre4aAr6JYpH0WDone61qsEvD1V8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=W+4EyS3l; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="W+4EyS3l" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1776234019; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=SLjSccDc2NIp2/wGYqd/TLfyKUp5TkLsnxrhbbYw5GQ=; b=W+4EyS3lqk+hRHUFnq5ljS4px9nwNiuTEkwkctZc2p7/uwEfgyEjOOiDsXSw7moWetlLW6t4dH7v1oBa+gxM0ptNV8vPEjxjjXqj5904b1kQ0DvSk2Yl7LRomcNy+eu6h5rQ/zuXJgiasB0Y6fnRkqPx428NH/exQJOQliTBZm4= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037033178;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=27;SR=0;TI=SMTPD_---0X13bDWp_1776234017; Received: from 30.74.144.121(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0X13bDWp_1776234017 cluster:ay36) by smtp.aliyun-inc.com; Wed, 15 Apr 2026 14:20:17 +0800 Message-ID: Date: Wed, 15 Apr 2026 14:20:16 +0800 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7.2 v2 04/12] mm: remove READ_ONLY_THP_FOR_FS Kconfig option To: Zi Yan , "Matthew Wilcox (Oracle)" , Song Liu Cc: Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20260413192030.3275825-1-ziy@nvidia.com> <20260413192030.3275825-5-ziy@nvidia.com> From: Baolin Wang In-Reply-To: <20260413192030.3275825-5-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/14/26 3:20 AM, Zi Yan wrote: > After removing READ_ONLY_THP_FOR_FS check in file_thp_enabled(), > khugepaged and MADV_COLLAPSE can run on FSes with PMD THP pagecache > support even without READ_ONLY_THP_FOR_FS enabled. Remove the Kconfig first > so that no one can use READ_ONLY_THP_FOR_FS as upcoming commits remove > mapping->nr_thps, which its safe guard mechanism relies on. > > Reviewed-by: Lorenzo Stoakes (Oracle) > Signed-off-by: Zi Yan > --- LGTM. Reviewed-by: Baolin Wang