From: Chris Mason <clm@fb.com>
To: Nikolay Borisov <nborisov@suse.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Move skip checksum check from btrfs_submit_direct to __btrfs_submit_dio_bio
Date: Thu, 3 Aug 2017 11:07:39 -0400 [thread overview]
Message-ID: <d5c7b3dd-268f-131f-ce57-dbc4ff5baf63@fb.com> (raw)
In-Reply-To: <1501764298-24522-1-git-send-email-nborisov@suse.com>
On 08/03/2017 08:44 AM, Nikolay Borisov wrote:
> Currently the code checks whether we should do data checksumming in
> btrfs_submit_direct and the boolean result of this check is passed to
> btrfs_submit_direct_hook, in turn passing it to __btrfs_submit_dio_bio which
> actually consumes it. The last function actually has all the necessary context
> to figure out whether to skip the check or not, so let's move the check closer
> to where it's being consumed. No functional changes.
I like it, thanks.
Reviewed-by: Chris Mason <clm@fb.com>
-chris
prev parent reply other threads:[~2017-08-03 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 12:44 [PATCH] btrfs: Move skip checksum check from btrfs_submit_direct to __btrfs_submit_dio_bio Nikolay Borisov
2017-08-03 15:07 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5c7b3dd-268f-131f-ce57-dbc4ff5baf63@fb.com \
--to=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).