From: Nikolay Borisov <nborisov@suse.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 12/35] btrfs: add ALLOC_CHUNK_FORCE to the flushing code
Date: Tue, 4 Sep 2018 21:22:54 +0300 [thread overview]
Message-ID: <d7daa0e0-b54c-499a-c486-6b295867d938@suse.com> (raw)
In-Reply-To: <20180904175755.3wyvm6psdsjgom4k@destiny>
On 4.09.2018 20:57, Josef Bacik wrote:
> On Mon, Sep 03, 2018 at 05:19:19PM +0300, Nikolay Borisov wrote:
>>
>>
>> On 30.08.2018 20:42, Josef Bacik wrote:
>>> + if (flush_state == ALLOC_CHUNK_FORCE && !commit_cycles)
>>> + flush_state++;
>>
>> This is a bit obscure. So if we allocated a chunk and !commit_cycles
>> just break from the loop? What's the reasoning behind this ?
>
> I'll add a comment, but it doesn't break the loop, it just goes to COMMIT_TRANS.
> The idea is we don't want to force a chunk allocation if we're experiencing a
> little bit of pressure, because we could end up with a drive full of empty
> metadata chunks. We want to try committing the transaction first, and then if
> we still have issues we can force a chunk allocation. Thanks,
I think it will be better if this check is moved up somewhere before the
the if (flush_state > commit trans).
>
> Josef
>
next prev parent reply other threads:[~2018-09-04 22:49 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:41 [PATCH 00/35] My current patch queue Josef Bacik
2018-08-30 17:41 ` [PATCH 01/35] btrfs: add btrfs_delete_ref_head helper Josef Bacik
2018-08-31 7:57 ` Nikolay Borisov
2018-08-31 14:13 ` Josef Bacik
2018-08-30 17:41 ` [PATCH 02/35] btrfs: add cleanup_ref_head_accounting helper Josef Bacik
2018-08-31 22:55 ` Omar Sandoval
2018-09-05 0:50 ` Liu Bo
2018-08-30 17:41 ` [PATCH 03/35] btrfs: use cleanup_extent_op in check_ref_cleanup Josef Bacik
2018-08-31 23:00 ` Omar Sandoval
2018-09-07 11:00 ` David Sterba
2018-08-30 17:41 ` [PATCH 04/35] btrfs: only track ref_heads in delayed_ref_updates Josef Bacik
2018-08-31 7:52 ` Nikolay Borisov
2018-08-31 14:10 ` Josef Bacik
2018-08-30 17:41 ` [PATCH 05/35] btrfs: introduce delayed_refs_rsv Josef Bacik
2018-09-04 15:21 ` Nikolay Borisov
2018-09-04 18:18 ` Josef Bacik
2018-08-30 17:41 ` [PATCH 06/35] btrfs: check if free bgs for commit Josef Bacik
2018-08-31 23:18 ` Omar Sandoval
2018-09-03 9:06 ` Nikolay Borisov
2018-09-03 13:19 ` Nikolay Borisov
2018-08-30 17:41 ` [PATCH 07/35] btrfs: dump block_rsv whe dumping space info Josef Bacik
2018-08-31 7:53 ` Nikolay Borisov
2018-08-31 14:11 ` Josef Bacik
2018-08-30 17:41 ` [PATCH 08/35] btrfs: release metadata before running delayed refs Josef Bacik
2018-09-01 0:12 ` Omar Sandoval
2018-09-03 9:13 ` Nikolay Borisov
2018-09-05 1:41 ` Liu Bo
2018-08-30 17:41 ` [PATCH 09/35] btrfs: protect space cache inode alloc with nofs Josef Bacik
2018-09-01 0:14 ` Omar Sandoval
2018-08-30 17:42 ` [PATCH 10/35] btrfs: fix truncate throttling Josef Bacik
2018-08-30 17:42 ` [PATCH 11/35] btrfs: don't use global rsv for chunk allocation Josef Bacik
2018-08-30 17:42 ` [PATCH 12/35] btrfs: add ALLOC_CHUNK_FORCE to the flushing code Josef Bacik
2018-09-03 14:19 ` Nikolay Borisov
2018-09-04 17:57 ` Josef Bacik
2018-09-04 18:22 ` Nikolay Borisov [this message]
2018-08-30 17:42 ` [PATCH 13/35] btrfs: reset max_extent_size properly Josef Bacik
2018-08-30 17:42 ` [PATCH 14/35] btrfs: don't enospc all tickets on flush failure Josef Bacik
2018-08-30 17:42 ` [PATCH 15/35] btrfs: run delayed iputs before committing Josef Bacik
2018-08-31 7:55 ` Nikolay Borisov
2018-08-31 14:12 ` Josef Bacik
2018-08-30 17:42 ` [PATCH 16/35] btrfs: loop in inode_rsv_refill Josef Bacik
2018-08-30 17:42 ` [PATCH 17/35] btrfs: move the dio_sem higher up the callchain Josef Bacik
2018-08-30 17:42 ` [PATCH 18/35] btrfs: set max_extent_size properly Josef Bacik
2018-08-30 17:42 ` [PATCH 19/35] btrfs: don't use ctl->free_space for max_extent_size Josef Bacik
2018-08-30 17:42 ` [PATCH 20/35] btrfs: reset max_extent_size on clear in a bitmap Josef Bacik
2018-09-05 1:44 ` Liu Bo
2018-08-30 17:42 ` [PATCH 21/35] btrfs: only run delayed refs if we're committing Josef Bacik
2018-09-01 0:28 ` Omar Sandoval
2018-09-04 17:54 ` Josef Bacik
2018-09-04 18:04 ` Omar Sandoval
2018-08-30 17:42 ` [PATCH 22/35] btrfs: make sure we create all new bgs Josef Bacik
2018-08-31 7:31 ` Nikolay Borisov
2018-08-31 14:03 ` Josef Bacik
2018-09-06 6:43 ` Liu Bo
2018-09-01 0:10 ` Omar Sandoval
2018-08-30 17:42 ` [PATCH 23/35] btrfs: assert on non-empty delayed iputs Josef Bacik
2018-09-01 0:21 ` Omar Sandoval
2018-08-30 17:42 ` [PATCH 24/35] btrfs: pass delayed_refs_root to btrfs_delayed_ref_lock Josef Bacik
2018-08-31 7:32 ` Nikolay Borisov
2018-08-30 17:42 ` [PATCH 25/35] btrfs: make btrfs_destroy_delayed_refs use btrfs_delayed_ref_lock Josef Bacik
2018-08-31 7:38 ` Nikolay Borisov
2018-08-30 17:42 ` [PATCH 26/35] btrfs: make btrfs_destroy_delayed_refs use btrfs_delete_ref_head Josef Bacik
2018-08-31 7:39 ` Nikolay Borisov
2018-08-30 17:42 ` [PATCH 27/35] btrfs: handle delayed ref head accounting cleanup in abort Josef Bacik
2018-08-31 7:42 ` Nikolay Borisov
2018-08-31 14:04 ` Josef Bacik
2018-08-30 17:42 ` [PATCH 28/35] btrfs: call btrfs_create_pending_block_groups unconditionally Josef Bacik
2018-08-31 7:43 ` Nikolay Borisov
2018-08-30 17:42 ` [PATCH 29/35] btrfs: just delete pending bgs if we are aborted Josef Bacik
2018-08-31 7:46 ` Nikolay Borisov
2018-08-31 14:05 ` Josef Bacik
2018-09-01 0:33 ` Omar Sandoval
2018-08-30 17:42 ` [PATCH 30/35] btrfs: cleanup pending bgs on transaction abort Josef Bacik
2018-08-31 7:48 ` Nikolay Borisov
2018-08-31 14:07 ` Josef Bacik
2018-09-01 0:34 ` Omar Sandoval
2018-08-30 17:42 ` [PATCH 31/35] btrfs: clear delayed_refs_rsv for dirty bg cleanup Josef Bacik
2018-08-30 17:42 ` [PATCH 32/35] btrfs: only free reserved extent if we didn't insert it Josef Bacik
2018-08-30 17:42 ` [PATCH 33/35] btrfs: fix insert_reserved error handling Josef Bacik
2018-09-07 6:44 ` Nikolay Borisov
2018-08-30 17:42 ` [PATCH 34/35] btrfs: wait on ordered extents on abort cleanup Josef Bacik
2018-09-07 6:49 ` Nikolay Borisov
2018-08-30 17:42 ` [PATCH 35/35] MAINTAINERS: update my email address for btrfs Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7daa0e0-b54c-499a-c486-6b295867d938@suse.com \
--to=nborisov@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).