Re: [PATCH] btrfs: include device major and minor numbers in the device scan notice

Filipe Manana
2024-02-23T15:47:24Z

On Fri, Feb 23, 2024 at 11:27 AM Anand Jain <anand.jain@oracle.com> wrote:
>
> To better debug issues surrounding device scans, include the device's
> major and minor numbers in the device scan notice for btrfs.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> fs/btrfs/volumes.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 32312f0de2bb..6db37615a3e5 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -824,13 +824,15 @@ static noinline struct btrfs_device *device_list_add(const char *path,
>
> if (disk_super->label[0])
> pr_info(
> - "BTRFS: device label %s devid %llu transid %llu %s scanned by %s (%d)\n",
> +"BTRFS: device label %s devid %llu transid %llu %s(%d:%d) scanned by %s (%d)\n",

Can we please leave a space before the opening parentheses?
So that it's consistent with the rest of the message and more readable
(I believe it's also more formal English).

> disk_super->label, devid, found_transid, path,
> + MAJOR(path_devt), MINOR(path_devt),
> current->comm, task_pid_nr(current));
> else
> pr_info(
> - "BTRFS: device fsid %pU devid %llu transid %llu %s scanned by %s (%d)\n",
> +"BTRFS: device fsid %pU devid %llu transid %llu %s(%d:%d) scanned by %s (%d)\n",

Same here.

With that adjusted:

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Thanks.

> disk_super->fsid, devid, found_transid, path,
> + MAJOR(path_devt), MINOR(path_devt),
> current->comm, task_pid_nr(current));
>
> } else if (!device->name || strcmp(device->name->str, path)) {
> --
> 2.38.1
>
>