From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 2/2] btrfs: pass bio_offset to check_data_csum() directly
Date: Thu, 12 Nov 2020 11:55:08 +0200 [thread overview]
Message-ID: <d8fd03fb-869d-0747-8b8c-1264d550e6c1@suse.com> (raw)
In-Reply-To: <20201112084758.73617-3-wqu@suse.com>
On 12.11.20 г. 10:47 ч., Qu Wenruo wrote:
> Parameter @icsum for check_data_csum() is a little hard to understand.
> So is the @phy_offset for btrfs_verify_data_csum().
>
> Both parameters are calculated values for csum lookup.
>
> Instead of some calculated value, just pass @bio_offset and let the
> final and only user, check_data_csum(), to calculate whatever it needs.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
That seems to be a simple rename + moving the conversion between
bytes->sectors into check_data_csum.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2020-11-12 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 8:47 [PATCH v3 0/2] btrfs: paramater refactors for data and metadata endio call backs Qu Wenruo
2020-11-12 8:47 ` [PATCH v3 1/2] btrfs: remove the phy_offset parameter for btrfs_validate_metadata_buffer() Qu Wenruo
2020-11-12 9:24 ` Johannes Thumshirn
2020-11-13 18:32 ` Josef Bacik
2020-11-12 8:47 ` [PATCH v3 2/2] btrfs: pass bio_offset to check_data_csum() directly Qu Wenruo
2020-11-12 9:30 ` Johannes Thumshirn
2020-11-12 9:55 ` Nikolay Borisov [this message]
2020-11-13 18:35 ` Josef Bacik
2020-11-16 16:14 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8fd03fb-869d-0747-8b8c-1264d550e6c1@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox