public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: fdmanana@kernel.org, fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH v2 0/8] fstests: btrfs: fix test failures when running with compression or nodatasum
Date: Fri, 14 Feb 2025 17:29:12 +0800	[thread overview]
Message-ID: <d9e2d806-dbf4-439e-9866-1c20de80a915@oracle.com> (raw)
In-Reply-To: <cover.1739403114.git.fdmanana@suse.com>

On 13/2/25 07:34, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Several tests fail when running with the compression or nodatasum mount
> options. This patchset fixes that by either skipping the tests when those
> mount options are present or adapting the tests to able to run.
> Details in the changelogs.
> 
> V2: Updated patch 5/8, the chattr must stay as we really want to create
>      an inline compressed extent, otherwise it wouldn't be exercising
>      cloning of an inline extent. So skip the test instead of nodatasum
>      is present and add a comment about it.
> 
>      Added some collect review tags.
> 


Looks good. Thx.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

Merged.

-Anand

> Filipe Manana (8):
>    btrfs: skip tests incompatible with compression when compression is enabled
>    btrfs/290: skip test if we are running with nodatacow mount option
>    common/btrfs: add a _require_btrfs_no_nodatasum helper
>    btrfs/333: skip the test when running with nodatacow or nodatasum
>    btrfs/205: skip test when running with nodatasum mount option
>    btrfs: skip tests exercising data corruption and repair when using nodatasum
>    btrfs/281: skip test when running with nodatasum mount option
>    btrfs: skip tests that exercise compression property when using nodatasum
> 
>   common/btrfs    |  7 +++++++
>   tests/btrfs/048 |  3 +++
>   tests/btrfs/059 |  3 +++
>   tests/btrfs/140 |  4 +++-
>   tests/btrfs/141 |  4 +++-
>   tests/btrfs/157 |  4 +++-
>   tests/btrfs/158 |  4 +++-
>   tests/btrfs/205 |  5 +++++
>   tests/btrfs/215 |  8 +++++++-
>   tests/btrfs/265 |  7 ++++++-
>   tests/btrfs/266 |  7 ++++++-
>   tests/btrfs/267 |  7 ++++++-
>   tests/btrfs/268 |  7 ++++++-
>   tests/btrfs/269 |  7 ++++++-
>   tests/btrfs/281 |  2 ++
>   tests/btrfs/289 |  8 ++++++--
>   tests/btrfs/290 | 12 ++++++++++++
>   tests/btrfs/297 |  4 ++++
>   tests/btrfs/333 |  5 +++++
>   19 files changed, 96 insertions(+), 12 deletions(-)
> 


      parent reply	other threads:[~2025-02-14  9:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 17:01 [PATCH 0/8] fstests: btrfs: fix test failure when running with compression or nodatasum fdmanana
2025-02-12 17:01 ` [PATCH 1/8] btrfs: skip tests incompatible with compression when compression is enabled fdmanana
2025-02-12 17:16   ` Johannes Thumshirn
2025-02-12 17:01 ` [PATCH 2/8] btrfs/290: skip test if we are running with nodatacow mount option fdmanana
2025-02-12 17:19   ` Johannes Thumshirn
2025-02-12 17:01 ` [PATCH 3/8] common/btrfs: add a _require_btrfs_no_nodatasum helper fdmanana
2025-02-12 17:20   ` Johannes Thumshirn
2025-02-12 17:01 ` [PATCH 4/8] btrfs/333: skip the test when running with nodatacow or nodatasum fdmanana
2025-02-12 17:21   ` Johannes Thumshirn
2025-02-12 17:01 ` [PATCH 5/8] btrfs/205: avoid test failure when running with nodatasum mount option fdmanana
2025-02-12 23:20   ` David Sterba
2025-02-12 17:01 ` [PATCH 6/8] btrfs: skip tests exercising data corruption and repair when using nodatasum fdmanana
2025-02-12 17:01 ` [PATCH 7/8] btrfs/281: skip test when running with nodatasum mount option fdmanana
2025-02-12 23:21   ` David Sterba
2025-02-12 17:01 ` [PATCH 8/8] btrfs: skip tests that exercise compression property when using nodatasum fdmanana
2025-02-12 23:21   ` David Sterba
2025-02-12 23:34 ` [PATCH v2 0/8] fstests: btrfs: fix test failures when running with compression or nodatasum fdmanana
2025-02-12 23:34   ` [PATCH v2 1/8] btrfs: skip tests incompatible with compression when compression is enabled fdmanana
2025-02-12 23:35   ` [PATCH v2 2/8] btrfs/290: skip test if we are running with nodatacow mount option fdmanana
2025-02-12 23:35   ` [PATCH v2 3/8] common/btrfs: add a _require_btrfs_no_nodatasum helper fdmanana
2025-02-12 23:35   ` [PATCH v2 4/8] btrfs/333: skip the test when running with nodatacow or nodatasum fdmanana
2025-02-12 23:35   ` [PATCH v2 5/8] btrfs/205: skip test when running with nodatasum mount option fdmanana
2025-02-13  9:40     ` Johannes Thumshirn
2025-02-12 23:35   ` [PATCH v2 6/8] btrfs: skip tests exercising data corruption and repair when using nodatasum fdmanana
2025-02-13  9:40     ` Johannes Thumshirn
2025-02-12 23:35   ` [PATCH v2 7/8] btrfs/281: skip test when running with nodatasum mount option fdmanana
2025-02-13  9:41     ` Johannes Thumshirn
2025-02-12 23:35   ` [PATCH v2 8/8] btrfs: skip tests that exercise compression property when using nodatasum fdmanana
2025-02-13  9:41     ` Johannes Thumshirn
2025-02-13  9:02   ` [PATCH v2 0/8] fstests: btrfs: fix test failures when running with compression or nodatasum Qu Wenruo
2025-02-14  9:29   ` Anand Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9e2d806-dbf4-439e-9866-1c20de80a915@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=fdmanana@kernel.org \
    --cc=fdmanana@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox