linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: dump-tree: add degraded option
Date: Thu, 12 Apr 2018 16:58:37 +0800	[thread overview]
Message-ID: <d9fe8756-8365-218b-da62-44ab09e0a2af@oracle.com> (raw)
In-Reply-To: <0c04295b-1b42-37be-579d-5c8b7867affb@gmx.com>



>> diff --git a/cmds-inspect-dump-tree.c b/cmds-inspect-dump-tree.c
>> index df44bb635c9c..d2676ce55af7 100644
>> --- a/cmds-inspect-dump-tree.c
>> +++ b/cmds-inspect-dump-tree.c
>> @@ -198,6 +198,7 @@ const char * const cmd_inspect_dump_tree_usage[] = {
>>   	"-u|--uuid              print only the uuid tree",
>>   	"-b|--block <block_num> print info from the specified block only",
>>   	"-t|--tree <tree_id>    print only tree with the given id (string or number)",
>> +	"-x|--noscan            use the disk in the arg, do not scan for the disks (for raid1)",
> 
> Still it looks a little too restrict.
> 
> What about some equivalent just like kernel "device=" mount option?

  You mean something like..

"-o  use the disk(s) in the arg, do not scan for additional disks",

    btrfs in dump-tree [options] -o [device=<dev1>,device=<dev2>] <dev3>
    btrfs in dump-tree [options] -o <dev>
    btrfs in dump-tree [options] -o <dev1> -o <dev2> <dev3>

  I am ok.

Thanks, Anand

      reply	other threads:[~2018-04-12  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 14:00 [PATCH] btrfs-progs: dump-tree: add degraded option Anand Jain
2018-03-09 16:23 ` David Sterba
2018-03-10  0:13   ` Anand Jain
2018-03-10 13:54   ` [PATCH v2] " Anand Jain
2018-03-12  0:23     ` Qu Wenruo
2018-04-12  8:58       ` Anand Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9fe8756-8365-218b-da62-44ab09e0a2af@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).