Re: [PATCH v2 5/8] btrfs-progs: mkfs: check if byte_count is zone size aligned

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2024/5/15 03:52, Naohiro Aota 写道:
> Creating a btrfs whose size is not aligned to the zone boundary is
> meaningless and allowing it can confuse users. Disallow creating it.

Can we just round it down and gives a warning?

I'm pretty sure some users are used to just passing some numbers like
1000000 to "-b" option.

And it may also be a good idea to do the same rounddown for non-zoned fs.

Thanks,
Qu
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---
>   mkfs/main.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/mkfs/main.c b/mkfs/main.c
> index a437ecc40c7f..faf397848cc4 100644
> --- a/mkfs/main.c
> +++ b/mkfs/main.c
> @@ -1655,6 +1655,11 @@ int BOX_MAIN(mkfs)(int argc, char **argv)
>   		      opt_zoned ? "zoned mode " : "", min_dev_size);
>   		goto error;
>   	}
> +	if (byte_count && opt_zoned && !IS_ALIGNED(byte_count, zone_size(file))) {
> +		error("size %llu is not aligned to zone size %llu", byte_count,
> +		      zone_size(file));
> +		goto error;
> +	}
>
>   	for (i = saved_optind; i < saved_optind + device_count; i++) {
>   		char *path;