Re: [PATCH] btrfs: remove unused btrfs_io_stripe::length

[Johannes Thumshirn <Johannes.Thumshirn@wdc.com>]

On 22.04.25 17:36, David Sterba wrote:
> First added (but not effectively used) in 02c372e1f016e5 ("btrfs: add
> support for inserting raid stripe extents"). The structure is
> initialized to zeros so the only use in btrfs_insert_one_raid_extent()
> 
>      u64 length = bioc->stripes[i].length;
>      struct btrfs_raid_stride *raid_stride = &stripe_extent->strides[i];
> 
>      if (length == 0)
>              length = bioc->size;
> 
> the 'if' always happens.
> 
> Last use in 4016358e852861 ("btrfs: remove unused variable length in
> btrfs_insert_one_raid_extent()") was an obvious cleanup. It seems to be
> safe to remove, raid-stripe-tree works without using it since 6.6.
> 
> This was found by tool https://github.com/jirislaby/clang-struct .
> 
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>   fs/btrfs/volumes.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 0e793b9776d677..d06d2d8713f87f 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -473,7 +473,6 @@ struct btrfs_io_stripe {
>   	struct btrfs_device *dev;
>   	/* Block mapping. */
>   	u64 physical;
> -	u64 length;
>   	bool rst_search_commit_root;
>   	/* For the endio handler. */
>   	struct btrfs_io_context *bioc;

Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>