From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use set functions to update latest refs to the SB
Date: Tue, 13 Feb 2018 10:56:39 +0800 [thread overview]
Message-ID: <de4979e1-f282-2017-3559-ce55adfc49e8@oracle.com> (raw)
In-Reply-To: <20180212163443.GI3003@twin.jikos.cz>
On 02/13/2018 12:34 AM, David Sterba wrote:
> On Mon, Feb 12, 2018 at 11:37:49PM +0800, Anand Jain wrote:
>> We have btrfs_set_super...() to set the various values, so just use it.
>
> Sorry but this is not "just use it", as it fixes an endianness bug and
> should be documented in the changelog. And there are probably more
> instances of the bug while accessing fs_info::super or
> fs_info::super_copy directly.
Will fix. Also checked rest of the code for similar misses in
reading/writing of fs_info::super_copy and fs_info::super_for_commit
values, but didn't find any further or did I miss something ?
Sent V2. With new title:
btrfs: fix endianness compatibility during the SB RW
Thanks, Anand
next prev parent reply other threads:[~2018-02-13 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 15:37 [PATCH] btrfs: use set functions to update latest refs to the SB Anand Jain
2018-02-12 16:34 ` David Sterba
2018-02-13 2:56 ` Anand Jain [this message]
2018-02-13 3:00 ` [PATCH v2] btrfs: fix endianness compatibility during the SB RW Anand Jain
2018-02-13 7:04 ` Nikolay Borisov
2018-02-13 9:01 ` Qu Wenruo
2018-02-13 10:27 ` Anand Jain
2018-02-13 10:39 ` Qu Wenruo
2018-02-13 17:55 ` David Sterba
2018-02-14 14:53 ` Anand Jain
2018-02-15 16:49 ` David Sterba
2018-02-20 17:16 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de4979e1-f282-2017-3559-ce55adfc49e8@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).