linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Tanmay Bhushan <007047221b@gmail.com>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: raid56: Fix stripes if vertical errors are found
Date: Mon, 16 Jan 2023 07:37:50 +0800	[thread overview]
Message-ID: <e103b9fb-9d73-efb5-2f70-9537e943fad0@gmx.com> (raw)
In-Reply-To: <20230115203215.8115-1-007047221b@gmail.com>



On 2023/1/16 04:32, Tanmay Bhushan wrote:
> We take two stripe numbers if vertical errors are found.
> In case it is just a pstripe it does not matter but in
> case of raid 6 it matters a both stripes need to be fixed.
> 
> Signed-off-by: Tanmay Bhushan <007047221b@gmail.com>

Oh, my bad, typical copy-and-paste error.

Should go in to the next rc.

Fixes: 7a3150723061 ("btrfs: raid56: do data csum verification during 
RMW cycle")

Thanks,
Qu
> ---
>   fs/btrfs/raid56.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index 6a2cf754912d..f35898a78b16 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -1886,7 +1886,7 @@ static int recover_vertical(struct btrfs_raid_bio *rbio, int sector_nr,
>   		sector->uptodate = 1;
>   	}
>   	if (failb >= 0) {
> -		ret = verify_one_sector(rbio, faila, sector_nr);
> +		ret = verify_one_sector(rbio, failb, sector_nr);
>   		if (ret < 0)
>   			goto cleanup;
>   

  reply	other threads:[~2023-01-15 23:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-15 20:32 [PATCH] btrfs: raid56: Fix stripes if vertical errors are found Tanmay Bhushan
2023-01-15 23:37 ` Qu Wenruo [this message]
2023-01-25 19:11 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e103b9fb-9d73-efb5-2f70-9537e943fad0@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=007047221b@gmail.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).