Re: [PATCH v2 0/4] btrfs: introduce btrfs specific bdev holder ops and implement mark_dead() call back

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/6/9 14:51, Christoph Hellwig 写道:
> No full reivew yet, but I think in the long run your maintainance
> burdern will be a lot lower if you implement my suggestion of using
> the generic code and adding a new devloss super_uperation.

The main problem here is, we didn't go through setup_bdev_super() at 
all, and the super_block structure itself only supports one bdev.

Thus even if we implement a devloss call back in super ops, it will 
still require quite some extra works to make btrfs to go through the 
setup_bdev_super().


Although I have to admit, if all btrfs bdevs go through fs_holder_ops, 
it indeed solves a lot of extra races more easily (freeze ioctl vs bdev 
freeze call back races).

> 
> This might require resurrecting my old holder cleanup that Johannes
> reposted about a year ago.
>
Maybe it's time to revive that series, mind to share the link to that 
series?

Thanks,
Qu