From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org, wqu@suse.com
Subject: Re: [PATCH] btrfs-progs: snapshot fix user message
Date: Tue, 26 Mar 2024 06:11:34 +0530 [thread overview]
Message-ID: <e2e42863-bc27-4780-b864-c9f1afb1f001@oracle.com> (raw)
In-Reply-To: <20240325213608.GQ14596@twin.jikos.cz>
On 3/26/24 03:06, David Sterba wrote:
> On Tue, Mar 19, 2024 at 07:41:29PM +0530, Anand Jain wrote:
>> The fstests depend on the output message of the create snapshot command,
>> and if it's changed, the tests fail. Bring back the original messages,
>> as they are also grammatically correct.
>
> I removed the 'a' for consistency with other messages. That fstests
> depend too much on what applications return is not a new thing and the
> breakage will happen once the user-facing error messages get updated as
> they get the priority.
Alright, I wasn't aware it was an intentional change. We need to update
the fstests test cases. I'll take care of it.
Thanks, Anand
prev parent reply other threads:[~2024-03-26 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 14:11 [PATCH] btrfs-progs: snapshot fix user message Anand Jain
2024-03-25 21:36 ` David Sterba
2024-03-26 0:41 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e42863-bc27-4780-b864-c9f1afb1f001@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox