From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 1/3] btrfs: backref: Introduce the skeleton of btrfs_backref_iterator
Date: Fri, 14 Feb 2020 11:24:08 +0200 [thread overview]
Message-ID: <e352690f-a368-282a-5328-2bd2237bbecf@suse.com> (raw)
In-Reply-To: <20200214081354.56605-2-wqu@suse.com>
<snip>
> + * This helper is here to determine if that's the case.
> + */
> +static inline bool btrfs_backref_has_tree_block_info(
> + struct btrfs_backref_iterator *iterator)
> +{
> + if (iterator->cur_key.type == BTRFS_EXTENT_ITEM_KEY &&
> + iterator->cur_ptr - iterator->item_ptr ==
> + sizeof(struct btrfs_extent_item))
> + return true;
> + return false;
> +}
> +
> +int btrfs_backref_iterator_start(struct btrfs_backref_iterator *iterator,
> + u64 bytenr);
> +int btrfs_backref_iterator_next(struct btrfs_backref_iterator *iterator);
You are exposing a function here which is not implemented. Remove this
line and add it in the next patch where you actually introduce
iterator_next.
> +
> #endif
>
next prev parent reply other threads:[~2020-02-14 9:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 8:13 [PATCH v2 0/3] Btrfs: relocation: Refactor build_backref_tree() using btrfs_backref_iterator infrastructure Qu Wenruo
2020-02-14 8:13 ` [PATCH v2 1/3] btrfs: backref: Introduce the skeleton of btrfs_backref_iterator Qu Wenruo
2020-02-14 8:53 ` Johannes Thumshirn
2020-02-14 9:19 ` Nikolay Borisov
2020-02-14 9:33 ` Qu Wenruo
2020-02-14 9:36 ` Nikolay Borisov
2020-02-14 9:24 ` Nikolay Borisov [this message]
2020-02-14 9:34 ` Qu Wenruo
2020-02-14 8:13 ` [PATCH v2 2/3] btrfs: backref: Implement btrfs_backref_iterator_next() Qu Wenruo
2020-02-14 9:25 ` Nikolay Borisov
2020-02-14 9:28 ` Nikolay Borisov
2020-02-14 9:35 ` Qu Wenruo
2020-02-14 8:13 ` [PATCH v2 3/3] btrfs: relocation: Use btrfs_backref_iterator infrastructure Qu Wenruo
2020-02-14 9:00 ` Johannes Thumshirn
2020-02-14 9:36 ` Qu Wenruo
2020-02-14 9:29 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e352690f-a368-282a-5328-2bd2237bbecf@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox