Re: [PATCH] btrfs: use the enums instead of int type in struct btrfs_block_group fields

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2026/4/20 23:24, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The 'disk_cache_state' and 'cached' fields are defined with an int type
> but all the values we assigned to them come from the enums
> btrfs_disk_cache_state and btrfs_caching_type. So change the type in the
> btrfs_block_group structure from int to these enums - in practice an enum
> is an int, so this is more for readability and clarity.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/block-group.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/block-group.h b/fs/btrfs/block-group.h
> index 60a3b1c0a8ab..790c2d467af5 100644
> --- a/fs/btrfs/block-group.h
> +++ b/fs/btrfs/block-group.h
> @@ -171,10 +171,10 @@ struct btrfs_block_group {
>   	unsigned long full_stripe_len;
>   	unsigned long runtime_flags;
>   
> -	int disk_cache_state;
> +	enum btrfs_disk_cache_state disk_cache_state;
>   
>   	/* Cache tracking stuff */
> -	int cached;
> +	enum btrfs_caching_type cached;
>   	struct btrfs_caching_control *caching_ctl;
>   
>   	struct btrfs_space_info *space_info;