Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Christoph Hellwig <hch@infradead.org>,
	Luca Stefani <luca.stefani.ge1@gmail.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] btrfs: Split remaining space to discard in chunks
Date: Tue, 3 Sep 2024 19:13:29 +0930	[thread overview]
Message-ID: <e5d765e8-e294-465f-adfc-ad4787116959@gmx.com> (raw)
In-Reply-To: <Zta6RR1gXPi7cRH3@infradead.org>



在 2024/9/3 16:57, Christoph Hellwig 写道:
> You'll also need add a EXPORT_SYMBOL_GPL for blk_alloc_discard_bio.

Just curious, shouldn't blk_ioctl_discard() also check frozen status to
prevent block device trim from block suspension?

And if that's the case, would it make more sense to move the signal and
freezing checks into blk_alloc_discard_bio()?

Thanks,
Qu

  reply	other threads:[~2024-09-03  9:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  7:16 [PATCH v3 0/2] btrfs: Don't block suspend during fstrim Luca Stefani
2024-09-03  7:16 ` [PATCH v3 1/3] btrfs: Always update fstrim_range on failure Luca Stefani
2024-09-03  7:16 ` [PATCH v3 2/3] btrfs: Split remaining space to discard in chunks Luca Stefani
2024-09-03  7:27   ` Christoph Hellwig
2024-09-03  9:43     ` Qu Wenruo [this message]
2024-09-04  4:13       ` Christoph Hellwig
2024-09-04  5:34         ` Qu Wenruo
2024-09-03 10:39   ` Luca Stefani
2024-09-03 19:39   ` David Sterba
2024-09-06 20:10   ` kernel test robot
2024-09-03  7:16 ` [PATCH v3 3/3] btrfs: Don't block system suspend during fstrim Luca Stefani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5d765e8-e294-465f-adfc-ad4787116959@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=hch@infradead.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.stefani.ge1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox