linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove unused function btrfs_async_submit_limit()
Date: Thu, 15 Feb 2018 10:29:10 +0200	[thread overview]
Message-ID: <e86cf203-fb50-d12c-39f1-1918d10c6acf@suse.com> (raw)
In-Reply-To: <20180215033607.14236-1-anand.jain@oracle.com>



On 15.02.2018 05:36, Anand Jain wrote:
> Commit [1] removed the need to use btrfs_async_submit_limit(), so
> delete it.
> 
> [1]
>  commit 736cd52e0c720103f52ab9da47b6cc3af6b083f6
>   Btrfs: remove nr_async_submits and async_submit_draining
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
>  fs/btrfs/disk-io.c | 8 --------
>  fs/btrfs/disk-io.h | 1 -
>  2 files changed, 9 deletions(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index aca906971abe..c412ad1f103b 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -709,14 +709,6 @@ blk_status_t btrfs_bio_wq_end_io(struct btrfs_fs_info *info, struct bio *bio,
>  	return 0;
>  }
>  
> -unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info)
> -{
> -	unsigned long limit = min_t(unsigned long,
> -				    info->thread_pool_size,
> -				    info->fs_devices->open_devices);
> -	return 256 * limit;
> -}
> -
>  static void run_one_async_start(struct btrfs_work *work)
>  {
>  	struct async_submit_bio *async;
> diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h
> index 301151a50ac1..e2ac6a14150a 100644
> --- a/fs/btrfs/disk-io.h
> +++ b/fs/btrfs/disk-io.h
> @@ -133,7 +133,6 @@ blk_status_t btrfs_wq_submit_bio(struct btrfs_fs_info *fs_info, struct bio *bio,
>  			u64 bio_offset, void *private_data,
>  			extent_submit_bio_hook_t *submit_bio_start,
>  			extent_submit_bio_hook_t *submit_bio_done);
> -unsigned long btrfs_async_submit_limit(struct btrfs_fs_info *info);
>  int btrfs_write_tree_block(struct extent_buffer *buf);
>  void btrfs_wait_tree_block_writeback(struct extent_buffer *buf);
>  int btrfs_init_log_root_tree(struct btrfs_trans_handle *trans,
> 

  reply	other threads:[~2018-02-15  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15  3:36 [PATCH] btrfs: remove unused function btrfs_async_submit_limit() Anand Jain
2018-02-15  8:29 ` Nikolay Borisov [this message]
2018-02-19 15:01   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e86cf203-fb50-d12c-39f1-1918d10c6acf@suse.com \
    --to=nborisov@suse.com \
    --cc=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).