From: Nikolay Borisov <nborisov@suse.com>
To: Sidong Yang <realwakka@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: scrub: warn if scrub started on a device has mq-deadline
Date: Mon, 7 Dec 2020 10:00:50 +0200 [thread overview]
Message-ID: <e9fbdfc9-f522-0fde-ac82-91101454365d@suse.com> (raw)
In-Reply-To: <20201205184929.22412-1-realwakka@gmail.com>
On 5.12.20 г. 20:49 ч., Sidong Yang wrote:
> Warn if scurb stared on a device that has mq-deadline as io-scheduler
> and point documentation. mq-deadline doesn't work with ionice value and
> it results performance loss. This warning helps users figure out the
> situation. This patch implements the function that gets io-scheduler
> from sysfs and check when scrub stars with the function.
NAK, use applications should be oblivious to what scheduler the admin
has set up. It's the responsibility of the admin to configure their
system properly, at most there could be a note that scrub is an
io-intensive process and leave the rest to the admin.
next prev parent reply other threads:[~2020-12-07 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 18:49 [PATCH] btrfs-progs: scrub: warn if scrub started on a device has mq-deadline Sidong Yang
2020-12-07 7:23 ` Johannes Thumshirn
2020-12-10 20:20 ` David Sterba
2020-12-11 6:50 ` Johannes Thumshirn
2020-12-11 15:53 ` David Sterba
2020-12-11 16:02 ` Johannes Thumshirn
2020-12-11 16:42 ` Johannes Thumshirn
2020-12-11 17:04 ` Graham Cobb
2020-12-12 10:34 ` Johannes Thumshirn
2020-12-12 11:05 ` Damien Le Moal
2020-12-12 16:44 ` Sidong Yang
2020-12-14 7:11 ` Johannes Thumshirn
2020-12-07 8:00 ` Nikolay Borisov [this message]
2020-12-10 20:16 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9fbdfc9-f522-0fde-ac82-91101454365d@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox