From: Milan Broz <gmazyland@gmail.com>
To: "Andrea Gelmini" <andrea.gelmini@gelma.net>,
"Michael Laß" <bevan@bi-co.net>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
Chris Murphy <lists@colorremedies.com>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
dm-devel@redhat.com
Subject: Re: fstrim discarding too many or wrong blocks on Linux 5.1, leading to data loss
Date: Mon, 20 May 2019 18:45:04 +0200 [thread overview]
Message-ID: <ea5552b8-7b6a-2516-d968-c3f3c731e159@gmail.com> (raw)
In-Reply-To: <CAK-xaQYakXcAbhfiH_VbqWkh+HBJD5N69ktnnA7OnWdhL6fDLA@mail.gmail.com>
On 20/05/2019 16:53, Andrea Gelmini wrote:
...
> Also, changing crypttab:
> root@glet:~# cat /etc/crypttab
> sda6_crypt UUID=fe03e2e6-b8b1-4672-8a3e-b536ac4e1539 none luks,discard
>
> removing discard didn't solve the issue.
This is very strange, disabling discard should reject every discard IO
on the dmcrypt layer. Are you sure it was really disabled?
Note, it is the root filesystem, so you have to regenerate initramfs
to update crypttab inside it.
Could you paste "dmsetup table" and "lsblk -D" to verify that discard flag
is not there?
(I mean dmsetup table with the zeroed key, as a default and safe output.)
Milan
next prev parent reply other threads:[~2019-05-20 16:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 22:16 Massive filesystem corruption after balance + fstrim on Linux 5.1.2 Michael Laß
2019-05-16 23:41 ` Qu Wenruo
2019-05-16 23:42 ` Chris Murphy
2019-05-17 17:37 ` Michael Laß
2019-05-18 4:09 ` Chris Murphy
2019-05-18 9:18 ` Michael Laß
2019-05-18 9:31 ` Roman Mamedov
2019-05-18 10:09 ` Michael Laß
2019-05-18 10:26 ` Qu Wenruo
2019-05-19 19:55 ` fstrim discarding too many or wrong blocks on Linux 5.1, leading to data loss Michael Laß
2019-05-20 11:38 ` [dm-devel] " Michael Laß
2019-05-21 16:46 ` Michael Laß
2019-05-21 19:00 ` Andrea Gelmini
2019-05-21 19:59 ` Michael Laß
2019-05-21 20:12 ` Mike Snitzer
2019-05-24 15:00 ` Andrea Gelmini
2019-05-24 15:10 ` Greg KH
[not found] ` <CAK-xaQYPs62v971zm1McXw_FGzDmh_vpz3KLEbxzkmrsSgTfXw@mail.gmail.com>
2019-05-20 13:58 ` Michael Laß
2019-05-20 14:53 ` Andrea Gelmini
2019-05-20 16:45 ` Milan Broz [this message]
2019-05-20 19:58 ` Michael Laß
2019-05-21 18:54 ` Andrea Gelmini
2019-05-28 12:36 ` Massive filesystem corruption after balance + fstrim on Linux 5.1.2 Christoph Anton Mitterer
2019-05-28 12:43 ` Michael Laß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea5552b8-7b6a-2516-d968-c3f3c731e159@gmail.com \
--to=gmazyland@gmail.com \
--cc=andrea.gelmini@gelma.net \
--cc=bevan@bi-co.net \
--cc=dm-devel@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lists@colorremedies.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox