From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B389C4338F for ; Thu, 12 Aug 2021 06:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06D8B60FE6 for ; Thu, 12 Aug 2021 06:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234417AbhHLGmH (ORCPT ); Thu, 12 Aug 2021 02:42:07 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:39456 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231253AbhHLGmG (ORCPT ); Thu, 12 Aug 2021 02:42:06 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 521611FF18; Thu, 12 Aug 2021 06:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1628750501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qWVpUkH7Wdhx3rGOMuQ1rpIm5+4jmKokqPXifQTRd3o=; b=YftcYR/pP+6IMozIZEY56kP+ZJ2PM4rp+JOf0gj9LUc4r9ubBeLXU41Xj6a/SCNzBA+nIX vB5G25mUvwHBSLFpnKigT6TNpRXbPIa82CCyCmnv+7u6rRspUkP6XEOdJnEkrpJ36b/AAZ nzLGzyzRfTPdHzvAAGGaSGd6bA8V/gg= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 2635B1363C; Thu, 12 Aug 2021 06:41:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id j0AXBqXCFGHLcQAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 06:41:41 +0000 Subject: Re: [PATCH 3/4] btrfs-progs: map-logical: loosen the required trees to open the filesystem To: Qu Wenruo , linux-btrfs@vger.kernel.org References: <20210812053508.175737-1-wqu@suse.com> <20210812053508.175737-4-wqu@suse.com> From: Nikolay Borisov Message-ID: Date: Thu, 12 Aug 2021 09:41:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210812053508.175737-4-wqu@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 12.08.21 г. 8:35, Qu Wenruo wrote: > For btrfs-map-logical, it only requires chunk tree to do the > logicla->physical mapping. > > All othe trees are not really needed. > > Loosen the required trees to make btrfs-map-logical to work better on > corrupted fs. > > Signed-off-by: Qu Wenruo > --- > btrfs-map-logical.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/btrfs-map-logical.c b/btrfs-map-logical.c > index 21f00fa20ce8..9f119d08bad8 100644 > --- a/btrfs-map-logical.c > +++ b/btrfs-map-logical.c > @@ -261,7 +261,8 @@ int main(int argc, char **argv) > radix_tree_init(); > cache_tree_init(&root_cache); > > - root = open_ctree(dev, 0, 0); > + root = open_ctree(dev, 0, OPEN_CTREE_PARTIAL | > + OPEN_CTREE_NO_BLOCK_GROUPS); nit: OPEN_CTREE_PARTIAL implies ignoring error when opening the csum and extent tress, since those trees are opened via setup_root_or_create_block. This tells me that OPEN_CTREE_NO_BLOCK_GROUPS is redundant and can be removed and replaced with simply OPEN_CTREE_PARTIAL. > if (!root) { > fprintf(stderr, "Open ctree failed\n"); > free(output_file); >