From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: tree-checker: Remove comprehensive root owner check
Date: Wed, 3 Apr 2019 17:22:13 +0300 [thread overview]
Message-ID: <eae55430-b07d-3c89-ece4-2271ba9b079e@suse.com> (raw)
In-Reply-To: <20190403115919.17049-2-wqu@suse.com>
On 3.04.19 г. 14:59 ч., Qu Wenruo wrote:
> Commit 1ba98d086fe3 ("Btrfs: detect corruption when non-root leaf has
> zero item") introduced comprehensive root owner checker.
>
> However it's pretty expensive tree search to locate the owner root,
> especially when it get reused by mandatory read and write time
> tree-checker.
>
> This patch will remove that check, and completely rely on owner based
> empty leaf check, which is much faster and still works fine for most
> case.
>
> And since we skip the old root owner check, now write time tree check
> can be merged with btrfs_check_leaf_full().
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2019-04-03 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 11:59 [PATCH 1/2] btrfs: tree-checker: Make write time tree checker verify the content of leaves Qu Wenruo
2019-04-03 11:59 ` [PATCH 2/2] btrfs: tree-checker: Remove comprehensive root owner check Qu Wenruo
2019-04-03 14:21 ` David Sterba
2019-04-03 14:26 ` Qu Wenruo
2019-04-03 15:00 ` David Sterba
2019-04-03 14:22 ` Nikolay Borisov [this message]
2019-04-03 14:12 ` [PATCH 1/2] btrfs: tree-checker: Make write time tree checker verify the content of leaves Nikolay Borisov
2019-04-03 14:20 ` Qu Wenruo
2019-04-03 14:13 ` David Sterba
2019-04-03 14:15 ` Qu Wenruo
2019-04-03 14:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eae55430-b07d-3c89-ece4-2271ba9b079e@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox