Re: [PATCH 00/12] btrfs: item helper prep work for snapshot_id

[Nikolay Borisov <nborisov@suse.com>]

On 8.03.22 г. 0:33 ч., Josef Bacik wrote:
> Hello,
> 
> I sent a bunch of patches previously to rework a lot of our helpers in
> preparation of adding the snapshot_id to the btrfs_header.  I missed a few
> important areas with those patches, so here's the remaining work to make it
> easier to expand the size of the btrfs_header.  These are general fixups and
> cleanups that don't rely on the extent tree v2 work.  Thanks,
> 
> Josef
> 
> Josef Bacik (12):
>    btrfs: move btrfs_node_key into ctree.h
>    btrfs: add a btrfs_node_key_ptr helper, convert the users
>    btrfs: introduce *_leaf_data helpers
>    btrfs: make BTRFS_LEAF_DATA_OFFSET take an eb arg
>    btrfs: pass eb to the node_key_ptr helpers
>    btrfs: pass eb to the item_nr_offset helper
>    btrfs: add snapshot_id to the btrfs_header and related defs
>    btrfs: move the header SETGET funcs
>    btrfs: move the super SETGET funcs
>    btrfs: move BTRFS_LEAF related definitions below super SETGET funcs
>    btrfs: const-ify fs_info for the compat flag handlers
>    btrfs: use _offset helpers instead of offsetof in generic_bin_search
> 
>   fs/btrfs/ctree.c                | 151 ++++++------
>   fs/btrfs/ctree.h                | 411 +++++++++++++++++---------------
>   fs/btrfs/extent_io.c            |   6 +-
>   fs/btrfs/struct-funcs.c         |   8 -
>   fs/btrfs/tree-checker.c         |   4 +-
>   fs/btrfs/tree-mod-log.c         |   4 +-
>   include/uapi/linux/btrfs_tree.h |   1 +
>   7 files changed, 303 insertions(+), 282 deletions(-)
> 

Overall LGTM:

Reviewed-by: Nikolay Borisov <nborisov@suse.com>