From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351581BF3F for ; Wed, 17 Jul 2024 07:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202154; cv=none; b=kFCbSY0RuAi23B5wxPA6Ej1UnV5+RY1lPsmUSIbx00akjrGxSM5ebgd0xoYrah9O9fjceoWipALe7paV8at1ARD+W9wf6olipocxT1Ti4/sv0mum9oya+UyLWJlM2OAK7GxhiFdPofTCtysLeK95az5xZpcvcw00jNeQUTUkrnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721202154; c=relaxed/simple; bh=lSLC07cWgDtQxlP0/I5aHy3V2kujSc6et2iDzwJlqi4=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=QSHLfshTjnbrgHhwcmrTN2mFAgK8Q4j5oMLmiDIphW5pa7n1AuIVzyEbowJVsYnSvMWqid/dWII5NPqhO5o/JabaKy/JKb0Z/tsA97kCOnajVWxRQULbcRmF4Eo+HdJUG7nE2OYHsxULMPsAteFx2DU+t+mLuCVey8LMKqnM08k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bKNhDQ1y; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bKNhDQ1y" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2eede876fcbso44364061fa.2 for ; Wed, 17 Jul 2024 00:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721202150; x=1721806950; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ovwn3DW6TedKlvHEbgoQx/5Vd4igDUlWIvl8s9WQmRU=; b=bKNhDQ1yjRmmYLayq3yw4+qDpdln2jjKus4BLXWvtS+ss4tLTy8zLkxeKw6V/XEn+b dyBWm24daUS5fUMTr28YHowcS1ckqvR2cBVpDbnAmaHHZNC+4VGv9tJeKciiiXunOp5j I1bfXRumxYshX+QHBnBijCVBMbMbxOZns09Rwa3ePsCE/ivo/dhEY9t2iS0lg0+/xHZL krkDuH6VUkcYPjyC0nCPa2XGmb37AhAHgDUnmUvrHVxFE+1eeSh57KxL68aYrYlU3Yzg vPyLFcANOjHxoXsHgWg8Ggtngm9LEuwAMIVYFHBTYBclh5I5N6w8vZU9RK4ZOOlqPlH4 Eqxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721202150; x=1721806950; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ovwn3DW6TedKlvHEbgoQx/5Vd4igDUlWIvl8s9WQmRU=; b=muZyDS4vxFuqhGGBZKQjcyLsSR2yAmD5TryTJSLjrp2ivxJWxenmc/WExZZW2t1iF+ 1chb9V35Wi6xom83DQ1kRaYKJ47HExmRnlipbC8hxbPzuP9uTUVRolVIza6A4OfVYbux MyevmiupRtATUhgp/haRY4hCcq+fdFWGd+ffO3G/k1K/xbfmu262GG7oj9/pvmM4V50F WfdM3oQObc9B6Pd7wkhZO5w2l295QqsF3wBaATkFGpLjZrl9+3dx8+CgDiz/Lkif9WQJ kXyPgyC/yQrqEEEvA/KFY/JBO4uIqdlmGG552qJPhVQ5xTU+DPkpInPu9wohZYLxqFT8 pA2w== X-Gm-Message-State: AOJu0Ywcz9ZO/bxCM5ZffG4/FQBzCYh0hni6xAgwfL65RWsQ99xt9IiL UktJgRcNR4n5VHce0PvjDmR9DQ2RX0/VeUhfOXsxskw+i4GPOd/bL5wDWrMUAOr65i1MEBGISiP v X-Google-Smtp-Source: AGHT+IEbmvUx2Tku1m7n3VYmkCoOi72VBlj6R2Ay0fT/hCS949+rAMA+wRCub2dH2lx/PEDFiZ28Nw== X-Received: by 2002:a05:651c:14d:b0:2eb:f472:e7d3 with SMTP id 38308e7fff4ca-2eefd04fa1emr6949041fa.6.1721202150087; Wed, 17 Jul 2024 00:42:30 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc38a81sm69966755ad.220.2024.07.17.00.42.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 00:42:28 -0700 (PDT) Message-ID: Date: Wed, 17 Jul 2024 17:12:23 +0930 Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] mm: skip memcg for certain address space From: Qu Wenruo To: linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: Content-Language: en-US Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJVBQkNOgemAAoJEMI9kfOh Jf6oapEH/3r/xcalNXMvyRODoprkDraOPbCnULLPNwwp4wLP0/nKXvAlhvRbDpyx1+Ht/3gW p+Klw+S9zBQemxu+6v5nX8zny8l7Q6nAM5InkLaD7U5OLRgJ0O1MNr/UTODIEVx3uzD2X6MR ECMigQxu9c3XKSELXVjTJYgRrEo8o2qb7xoInk4mlleji2rRrqBh1rS0pEexImWphJi+Xgp3 dxRGHsNGEbJ5+9yK9Nc5r67EYG4bwm+06yVT8aQS58ZI22C/UeJpPwcsYrdABcisd7dddj4Q RhWiO4Iy5MTGUD7PdfIkQ40iRcQzVEL1BeidP8v8C4LVGmk4vD1wF6xTjQRKfXHOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJuBQkNOge/AAoJEMI9kfOhJf6o rq8H/3LJmWxL6KO2y/BgOMYDZaFWE3TtdrlIEG8YIDJzIYbNIyQ4lw61RR+0P4APKstsu5VJ 9E3WR7vfxSiOmHCRIWPi32xwbkD5TwaA5m2uVg6xjb5wbdHm+OhdSBcw/fsg19aHQpsmh1/Q bjzGi56yfTxxt9R2WmFIxe6MIDzLlNw3JG42/ark2LOXywqFRnOHgFqxygoMKEG7OcGy5wJM AavA+Abj+6XoedYTwOKkwq+RX2hvXElLZbhYlE+npB1WsFYn1wJ22lHoZsuJCLba5lehI+// ShSsZT5Tlfgi92e9P7y+I/OzMvnBezAll+p/Ly2YczznKM5tV0gboCWeusM= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Ping? Any feedback? I guess in this case btrfs is really the only one can benefit from this feature? Thanks, Qu 在 2024/7/10 10:37, Qu Wenruo 写道: > Recently I'm hitting soft lockup if adding an order 2 folio to a > filemap using GFP_NOFS | __GFP_NOFAIL. The softlockup happens at memcg > charge code, and I guess that's exactly what __GFP_NOFAIL is expected to > do, wait indefinitely until the request can be met. > > On the other hand, if we do not use __GFP_NOFAIL, we can be limited by > memcg at a lot of critical location, and lead to unnecessary transaction > abort just due to memcg limit. > > However for that specific btrfs call site, there is really no need charge > the memcg, as that address space belongs to btree inode, which is not > accessible to any end user, and that btree inode is a shared pool for > all metadata of a btrfs. > > So this patchset introduces a new address space flag, AS_NO_MEMCG, so > that folios added to that address space will not trigger any memcg > charge. > > This would be the basis for future btrfs changes, like removing > __GFP_NOFAIL completely and larger metadata folios. > > Qu Wenruo (2): > mm: make lru_gen_eviction() to handle folios without memcg info > mm: allow certain address space to be not accounted by memcg > > fs/btrfs/disk-io.c | 1 + > include/linux/pagemap.h | 1 + > mm/filemap.c | 12 +++++++++--- > mm/workingset.c | 2 +- > 4 files changed, 12 insertions(+), 4 deletions(-) >