From: Nikolay Borisov <nborisov@suse.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v4 6/6] btrfs: run delayed refs less often in commit_cowonly_roots
Date: Fri, 18 Dec 2020 11:26:33 +0200 [thread overview]
Message-ID: <eeb17ea5-1c75-832f-d894-c51a3d1264d0@suse.com> (raw)
In-Reply-To: <52a20cfa753203a17ecb01b20e02f6976cc097a8.1608215738.git.josef@toxicpanda.com>
On 17.12.20 г. 16:36 ч., Josef Bacik wrote:
> We love running delayed refs in commit_cowonly_roots, but it is a bit
> excessive. I was seeing cases of running 3 or 4 refs a few times in a
> row during this time. Instead simply update all of the roots first,
> then run delayed refs, then handle the empty block groups case, and then
> if we have any more dirty roots do the whole thing again. This allows
> us to be much more efficient with our delayed ref running, as we can
> batch a few more operations at once.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
prev parent reply other threads:[~2020-12-18 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1608215738.git.josef@toxicpanda.com>
2020-12-17 14:35 ` [PATCH v4 1/6] btrfs: do not block on deleted bgs mutex in the cleaner Josef Bacik
2020-12-17 14:35 ` [PATCH v4 2/6] btrfs: only let one thread pre-flush delayed refs in commit Josef Bacik
2020-12-17 14:35 ` [PATCH v4 3/6] btrfs: delayed refs pre-flushing should only run the heads we have Josef Bacik
2020-12-17 14:36 ` [PATCH v4 4/6] btrfs: only run delayed refs once before committing Josef Bacik
2020-12-17 14:36 ` [PATCH v4 5/6] btrfs: stop running all delayed refs during snapshot Josef Bacik
2020-12-18 9:26 ` Nikolay Borisov
2020-12-18 15:51 ` Josef Bacik
2020-12-17 14:36 ` [PATCH v4 6/6] btrfs: run delayed refs less often in commit_cowonly_roots Josef Bacik
2020-12-18 9:26 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb17ea5-1c75-832f-d894-c51a3d1264d0@suse.com \
--to=nborisov@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox