From: Jeff Mahoney <jeffm@suse.com>
To: dsterba@suse.cz, Nikolay Borisov <nborisov@suse.com>,
linux-btrfs@vger.kernel.org
Subject: [PATCH v2] btrfs: qgroup, don't try to insert status item after ENOMEM in rescan worker
Date: Fri, 27 Apr 2018 12:11:00 -0400 [thread overview]
Message-ID: <eec3082b-a8e2-1adb-f1f9-27c20a92dbd3@suse.com> (raw)
In-Reply-To: <b688d761-ff7f-2fe8-484d-f29eac58a0b5@suse.com>
If we fail to allocate memory for a path, don't bother trying to
insert the qgroup status item. We haven't done anything yet and it'll
fail also. Just print an error and be done with it.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
fs/btrfs/qgroup.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 8de423a0c7e3..b795bad54705 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -2648,7 +2648,6 @@ static void btrfs_qgroup_rescan_worker(struct btrfs_work *work)
btrfs_end_transaction(trans);
}
-out:
btrfs_free_path(path);
mutex_lock(&fs_info->qgroup_rescan_lock);
@@ -2684,13 +2683,13 @@ static void btrfs_qgroup_rescan_worker(struct btrfs_work *work)
if (btrfs_fs_closing(fs_info)) {
btrfs_info(fs_info, "qgroup scan paused");
- } else if (err >= 0) {
+ err = 0;
+ } else if (err >= 0)
btrfs_info(fs_info, "qgroup scan completed%s",
err > 0 ? " (inconsistency flag cleared)" : "");
- } else {
+out:
+ if (err < 0)
btrfs_err(fs_info, "qgroup scan failed with %d", err);
- }
-
done:
mutex_lock(&fs_info->qgroup_rescan_lock);
fs_info->qgroup_rescan_running = false;
--
2.12.3
next prev parent reply other threads:[~2018-04-27 16:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 19:23 [PATCH 1/3] btrfs: qgroups, fix rescan worker running races jeffm
2018-04-26 19:23 ` [PATCH 2/3] btrfs: qgroups, remove unnecessary memset before btrfs_init_work jeffm
2018-04-26 20:37 ` Nikolay Borisov
2018-04-26 19:23 ` [PATCH 3/3] btrfs: qgroup, don't try to insert status item after ENOMEM in rescan worker jeffm
2018-04-26 20:39 ` Nikolay Borisov
2018-04-27 15:44 ` David Sterba
2018-04-27 16:08 ` Jeff Mahoney
2018-04-27 16:11 ` Jeff Mahoney [this message]
2018-04-27 16:34 ` [PATCH v2] " David Sterba
2018-04-27 8:42 ` [PATCH 1/3] btrfs: qgroups, fix rescan worker running races Nikolay Borisov
2018-04-27 8:48 ` Filipe Manana
2018-04-27 16:00 ` Jeff Mahoney
2018-04-27 15:56 ` David Sterba
2018-04-27 16:02 ` Jeff Mahoney
2018-04-27 16:40 ` David Sterba
2018-04-27 19:32 ` Jeff Mahoney
2018-04-28 17:09 ` David Sterba
2018-04-27 19:28 ` Noah Massey
2018-04-28 17:10 ` David Sterba
2018-04-30 6:20 ` Qu Wenruo
2018-04-30 14:07 ` Jeff Mahoney
2018-05-02 10:29 ` David Sterba
2018-05-02 13:15 ` David Sterba
2018-05-02 13:58 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec3082b-a8e2-1adb-f1f9-27c20a92dbd3@suse.com \
--to=jeffm@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).