Re: [PATCH] btrfs-progs: do not BUG_ON if btrfs_add_to_fsid succeeded to write superblock

[Su Yue <l@damenly.su>]

On Fri 14 May 2021 at 19:22, David Sterba <dsterba@suse.cz> wrote:

> On Thu, May 13, 2021 at 08:37:29AM +0800, Su Yue wrote:
>>
>> On Wed 12 May 2021 at 22:01, David Sterba <dsterba@suse.cz> 
>> wrote:
>>
>> > On Tue, May 11, 2021 at 12:25:01PM +0800, Su Yue wrote:
>> >> Commit 8ef9313cf298 ("btrfs-progs: zoned: implement
>> >> log-structured
>> >> superblock") changed to write BTRFS_SUPER_INFO_SIZE bytes to
>> >> device.
>> >> The before num of bytes to be written is sectorsize.
>> >> It causes mkfs.btrfs failed on my 16k pagesize kvm:
>> >
>> > What architecture is that?
>> >
>> The host chip is Apple m1 so it's arm64 but only supporting 16k 
>> and 4k
>> pagesize. Since btrfs subpage work cares 64k pagesize for now, 
>> I
>> usually run xfstests with 16k pagesize and 16k sectorsize. So 
>> far, so
>> good.
>
> Interesting, what's the distro? I haven't found one that would 
> be
> pre-built with 16k pages so I assume it's built from scratch. 
> Among all
>

Right, I initially booted the kvm using Ubuntu kernel built with 
4k
pages then compiled 16k pagesize kernel manully.

--
Su
> the page sizes we've seen so far 4k is almost everywhere, 64k is 
> ppc and
> arm (both native), and sparc has 8k. 16k is a new one, though I 
> don't
> think it would catch something we haven't seen so far it adds a 
> bit to
> the CPU capabilities coverage.
>