Re: [PATCH 2/3] btrfs: pass true to btrfs_delalloc_release_space() at btrfs_page_mkwrite()

[Qu Wenruo <wqu@suse.com>]

在 2025/5/14 19:59, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> In the last call to btrfs_delalloc_release_space() where the value of the
> variable 'ret' is never zero, we pass the expression 'ret != 0' as the
> value for the argument 'qgroup_free', which always evaluates to true.
> Make this less confusing and more clear by explicitly passing true
> instead.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index 32aad1b02b01..a2b1fc536fdd 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -1971,7 +1971,7 @@ static vm_fault_t btrfs_page_mkwrite(struct vm_fault *vmf)
>   out:
>   	btrfs_delalloc_release_extents(BTRFS_I(inode), fsize);
>   	btrfs_delalloc_release_space(BTRFS_I(inode), data_reserved, page_start,
> -				     reserved_space, (ret != 0));
> +				     reserved_space, true);
>   out_noreserve:
>   	sb_end_pagefault(inode->i_sb);
>   	extent_changeset_free(data_reserved);