Re: [PATCH] btrfs: remove duplicate journal_info reset on failure to commit transaction

[Anand Jain <anajain.sg@gmail.com>]

Looks good.

Reviewed-by: Anand Jain <asj@kernel.org>




On 2/4/26 02:55, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> If we get an error during the transaction commit path, we are resetting
> current->journal_info to NULL twice - once in btrfs_commit_transaction()
> right before calling cleanup_transaction() and then once again inside
> cleanup_transaction(). Remove the instance in btrfs_commit_transaction().
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
>  fs/btrfs/transaction.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index c9c316ce4bdc..248adb785051 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -2657,8 +2657,6 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans)
>  	btrfs_trans_release_chunk_metadata(trans);
>  	trans->block_rsv = NULL;
>  	btrfs_warn(fs_info, "Skipping commit of aborted transaction.");
> -	if (current->journal_info == trans)
> -		current->journal_info = NULL;
>  	cleanup_transaction(trans, ret);
>  
>  	return ret;