Re: [PATCH v2] btrfs: fix missing endianess conversion in sb_write_pointer

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

On 2022/11/15 17:39, Christoph Hellwig wrote:
> generation is an on-disk __le64 value, so use btrfs_super_generation to
> convert it to host endian before comparing it.
> 
> Fixes: 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode")
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
> 
> Changes since v1:
>   - use btrfs_super_generation instead of le64_to_cpu
> 
>   fs/btrfs/zoned.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> index 6781c141a6b41..4b55a5c68826f 100644
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -137,7 +137,8 @@ static int sb_write_pointer(struct block_device *bdev, struct blk_zone *zones,
>   			super[i] = page_address(page[i]);
>   		}
>   
> -		if (super[0]->generation > super[1]->generation)
> +		if (btrfs_super_generation(super[0]) >
> +		    btrfs_super_generation(super[1]))
>   			sector = zones[1].start;
>   		else
>   			sector = zones[0].start;