linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lauri Võsandi" <lauri.vosandi@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: "Lauri Võsandi" <lauri.vosandi@gmail.com>
Subject: [PATCH] Btrfs receive hardening patches
Date: Tue, 14 Apr 2015 12:17:46 +0300	[thread overview]
Message-ID: <f79c8b9a79ecd8a87bb75fc7cb0b0d478a757f4b.1429002759.git.lauri.vosandi@gmail.com> (raw)

---
 cmds-receive.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/cmds-receive.c b/cmds-receive.c
index 44ef27e..6800401 100644
--- a/cmds-receive.c
+++ b/cmds-receive.c
@@ -867,15 +867,19 @@ static int do_receive(struct btrfs_receive *r, const char *tomnt, int r_fd,
 		goto out;
 	}
 
-	/*
-	 * find_mount_root returns a root_path that is a subpath of
-	 * dest_dir_full_path. Now get the other part of root_path,
-	 * which is the destination dir relative to root_path.
+	/**
+	 * Enforce chroot before parsing btrfs stream
 	 */
-	r->dest_dir_path = dest_dir_full_path + strlen(r->root_path);
-	while (r->dest_dir_path[0] == '/')
-		r->dest_dir_path++;
+	if (chroot(dest_dir_full_path)) {
+		fprintf(stderr,
+			"ERROR: failed to chroot to %s\n",
+			dest_dir_full_path);
+		ret = -errno;
+		goto out;
+	}
 
+	r->root_path = r->dest_dir_path = strdup("/");
+	
 	ret = subvol_uuid_search_init(r->mnt_fd, &r->sus);
 	if (ret < 0)
 		goto out;
-- 
1.9.1


                 reply	other threads:[~2015-04-14  9:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f79c8b9a79ecd8a87bb75fc7cb0b0d478a757f4b.1429002759.git.lauri.vosandi@gmail.com \
    --to=lauri.vosandi@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).