Re: [PATCH] btrfs: stop printing condition result in assertion failure messages

[Qu Wenruo <wqu@suse.com>]

在 2026/2/20 02:15, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> It's useless to print the result of the condition, it's always 0 if the
> assertion is triggered, so it doesn't provide any useful information.
> Examples:
> 
>     assertion failed: cb->bbio.bio.bi_iter.bi_size == disk_num_bytes :: 0, in inode.c:9991
>     assertion failed: folio_test_writeback(folio) :: 0, in subpage.c:476
> 
> So stop printing that, it's always ":: 0" for any assertion triggered.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/messages.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/btrfs/messages.h b/fs/btrfs/messages.h
> index 81f59afe4a99..17cdc14dc89d 100644
> --- a/fs/btrfs/messages.h
> +++ b/fs/btrfs/messages.h
> @@ -141,11 +141,11 @@ do {										\
>   	verify_assert_printk_format("check the format string" args);		\
>   	if (!likely(cond)) {							\
>   		if (("" __FIRST_ARG(args) [0]) == 0) {				\
> -			pr_err("assertion failed: %s :: %ld, in %s:%d\n",	\
> -				#cond, (long)(cond), __FILE__, __LINE__);	\
> +			pr_err("assertion failed: %s, in %s:%d\n",		\
> +				#cond, __FILE__, __LINE__);			\
>   		} else {							\
> -			pr_err("assertion failed: %s :: %ld, in %s:%d (" __FIRST_ARG(args) ")\n", \
> -				#cond, (long)(cond), __FILE__, __LINE__ __REST_ARGS(args)); \
> +			pr_err("assertion failed: %s, in %s:%d (" __FIRST_ARG(args) ")\n", \
> +				#cond, __FILE__, __LINE__ __REST_ARGS(args));	\
>   		}								\
>   		BUG();								\
>   	}									\