From: Nikolay Borisov <nborisov@suse.com>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: btrfs: extent_map: Change return type of unpin_extent_cache
Date: Tue, 2 Jul 2019 08:39:41 +0300 [thread overview]
Message-ID: <fa67e273-1f0a-15ae-c6df-98fc3060dcbe@suse.com> (raw)
In-Reply-To: <20190702031043.GA24334@hari-Inspiron-1545>
On 2.07.19 г. 6:10 ч., Hariprasad Kelam wrote:
> As unpin_extent_cache never fails and Caller does not expect return
> value we can change return value from int to void.
>
> Issue identified with coccicheck
> fs/btrfs/extent_map.c:284:5-8: Unneeded variable: "ret". Return "0" on
> line 316
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
prev parent reply other threads:[~2019-07-02 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 3:10 [PATCH] fs: btrfs: extent_map: Change return type of unpin_extent_cache Hariprasad Kelam
2019-07-02 5:39 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa67e273-1f0a-15ae-c6df-98fc3060dcbe@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hariprasad.kelam@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox