From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Naohiro Aota <Naohiro.Aota@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 07/12] btrfs-progs: zoned: factor out SINGLE zone info loading
Date: Mon, 17 Feb 2025 17:16:19 +0000 [thread overview]
Message-ID: <fc0340b1-9600-4bf4-b82f-e7d699206798@wdc.com> (raw)
In-Reply-To: <47145e0a-29f0-4bf7-ace6-97f226f73c15@wdc.com>
On 17.02.25 18:13, Johannes Thumshirn wrote:
> On 17.02.25 03:39, Naohiro Aota wrote:
>> - /* SINGLE profile case. */
>> - cache->alloc_offset = zone_info[0].alloc_offset;
>> - cache->zone_capacity = zone_info[0].capacity;
>> - cache->zone_is_active = test_bit(0, active);
>> +
>> + profile = map->type & BTRFS_BLOCK_GROUP_PROFILE_MASK;
>> + switch (profile) {
>> + case 0: /* single */
>> + ret = btrfs_load_block_group_single(fs_info, cache, &zone_info[0], active);
>> + break;
>> + case BTRFS_BLOCK_GROUP_RAID5:
>> + case BTRFS_BLOCK_GROUP_RAID6:
>> + default:
>> + error("zoned: profile %s not yet supported",
>> + btrfs_bg_type_to_raid_name(map->type));
>> + ret = -EINVAL;
>> + goto out;
>> + }
>
> The above is missing RAID0/1/10. Which on a non-experimental build
> should also error out. I see patch 9 is adding RAID1 but I think this
> patch needs to add the cases as well and error out (for now).
>
And DUP obviously as well sorry.
next prev parent reply other threads:[~2025-02-17 17:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 2:37 [PATCH 00/12] btrfs-progs: zoned: support zone capacity and Naohiro Aota
2025-02-17 2:37 ` [PATCH 01/12] btrfs-progs: introduce min_not_zero() Naohiro Aota
2025-02-17 2:37 ` [PATCH 02/12] btrfs-progs: zoned: introduce a zone_info struct in btrfs_load_block_group_zone_info Naohiro Aota
2025-02-17 2:37 ` [PATCH 03/12] btrfs-progs: zoned: support zone capacity Naohiro Aota
2025-02-17 2:37 ` [PATCH 04/12] btrfs-progs: zoned: load zone activeness Naohiro Aota
2025-02-17 2:37 ` [PATCH 05/12] btrfs-progs: zoned: activate block group on loading Naohiro Aota
2025-02-17 2:37 ` [PATCH 06/12] btrfs-progs: factor out btrfs_load_zone_info() Naohiro Aota
2025-02-17 2:37 ` [PATCH 07/12] btrfs-progs: zoned: factor out SINGLE zone info loading Naohiro Aota
2025-02-17 17:12 ` Johannes Thumshirn
2025-02-17 17:16 ` Johannes Thumshirn [this message]
2025-02-17 2:37 ` [PATCH 08/12] btrfs-progs: zoned: implement DUP " Naohiro Aota
2025-02-17 2:37 ` [PATCH 09/12] btrfs-progs: zoned: implement RAID1 " Naohiro Aota
2025-02-17 2:37 ` [PATCH 10/12] btrfs-progs: zoned: implement RAID0 " Naohiro Aota
2025-02-17 2:37 ` [PATCH 11/12] btrfs-progs: implement RAID10 " Naohiro Aota
2025-02-17 2:37 ` [PATCH 12/12] btrfs-progs: zoned: fix alloc_offset calculation for partly conventional block groups Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc0340b1-9600-4bf4-b82f-e7d699206798@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox