From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, Nikolay Borisov <nborisov@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: scrub: fix circular locking dependency warning
Date: Fri, 30 Nov 2018 09:05:53 +0800 [thread overview]
Message-ID: <fdb7bc42-48b6-8c1c-486a-abda8900b3e6@oracle.com> (raw)
In-Reply-To: <20181129143133.GA2842@twin.jikos.cz>
On 11/29/2018 10:31 PM, David Sterba wrote:
> On Wed, Nov 28, 2018 at 04:47:27PM +0800, Anand Jain wrote:
>>> 2. scrub_workers_refcnt must eventually be converted to refcount_t type
>>
>> ok. Added in v2 patch set.
>
> No such thing is in v2 and this would actually get rid of the need to
> hold scrub_lock in scrub_workers_put. Which in turn can be moved out of
> the locked section in btrfs_scrub_dev and the warning is gone. Problem
> solved.
>
Right. When testing btrfs/011 it got hung and bisect pointed to the
patch which was converting int to refcount_t.
I had difficulties to get the logs out of the test machines, so I
had to drop the patch.
Will send refcount_t patch, patch 1/3 and possibly scrub concurrency
patch (make scrub independent of the btrfs-progs locks) patches all
together.
Thanks, Anand
next prev parent reply other threads:[~2018-11-30 1:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 9:07 [PATCH 0/2] btrfs: scrub: fix scrub_lock Anand Jain
2018-11-26 9:07 ` [PATCH 1/2] btrfs: scrub: maintain the unlock order in scrub thread Anand Jain
2018-11-26 9:47 ` Nikolay Borisov
2018-11-27 13:37 ` Anand Jain
2018-11-26 9:07 ` [PATCH 2/2] btrfs: scrub: fix circular locking dependency warning Anand Jain
2018-11-26 9:59 ` Nikolay Borisov
2018-11-28 8:47 ` Anand Jain
2018-11-29 14:31 ` David Sterba
2018-11-30 1:05 ` Anand Jain [this message]
2018-11-30 5:28 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb7bc42-48b6-8c1c-486a-abda8900b3e6@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).