Re: [PATCH 1/8] btrfs: remove the alignment checks in end_bbio_data_read

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/4/10 15:00, Christoph Hellwig 写道:
> On Thu, Apr 10, 2025 at 07:43:54AM +0930, Qu Wenruo wrote:
>> The old comment indeed is incorrect, but can we still leave an ASSERT()
>> just in case to case any unaligned submission?
>>
>> It shouldn't cause anything different for end users, but should greatly
>> improve the life of quality for developers.
>
> What is is trying to check for? fi.offset isn't really a meaningful value
> to check for as it's just an offset into the folio.  bi_sector would be
> useful, but it's not owned by the file system after the bio was submitted.
> Maybe adding that assert to the submission path would make sense?  Remember
> that the bio completed is exactly the one submitted by the file system,
> and cloned split bio never reaches back into the file systems.

OK, it makes more sense, and we already have the alignment checks in the
write path (submit_one_sector()).

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu